Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 27066005: cc: Ref count pixel ref in image decode task. (Closed)

Created:
7 years, 2 months ago by vmpstr
Modified:
7 years, 2 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Ref count pixel ref in image decode task. This patch ensures that pixel ref will be valid when the image decode task runs. As it stands right now, there is a possibility that pixel ref will be accessed after it is freed (by the containing picture pile). BUG=305012 R=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cc/resources/raster_worker_pool.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vmpstr
Please take a look.
7 years, 2 months ago (2013-10-11 22:23:40 UTC) #1
reveman
lgtm
7 years, 2 months ago (2013-10-14 15:10:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/27066005/1
7 years, 2 months ago (2013-10-14 16:04:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/27066005/1
7 years, 2 months ago (2013-10-14 17:58:51 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-14 18:14:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/27066005/1
7 years, 2 months ago (2013-10-14 18:17:09 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-14 19:33:16 UTC) #7
Message was sent while issue was closed.
Change committed as 228506

Powered by Google App Engine
This is Rietveld 408576698