Chromium Code Reviews Chromium Code Reviews
Issue 2706583002:
Fix the way <title> is read under <use> shadow tree (Closed)
| Index: third_party/WebKit/LayoutTests/svg/dom/tooltip-title-with-use.html |
| diff --git a/third_party/WebKit/LayoutTests/svg/dom/tooltip-title-with-use.html b/third_party/WebKit/LayoutTests/svg/dom/tooltip-title-with-use.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..14f33804c62ce6c881b8e5409866c6bda37a1ccf |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/svg/dom/tooltip-title-with-use.html |
| @@ -0,0 +1,39 @@ |
| +<!DOCTYPE html> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<svg width="400" height="400"> |
| + <symbol id="greenSquare"> |
| + <title>Title in Symbol</title> |
| + <rect width="50" height="50" fill="green"> |
| + <title>Title in Rect</title> |
| + </rect> |
| + </symbol> |
| + <symbol id="blueSquare"> |
| + <rect width="50" height="50" fill="red"> |
|
fs
2017/03/03 08:53:30
Nit: red -> blue
mrunal
2017/03/03 20:09:40
Aahh...Done. Thanks.
|
| + <title>Title in Rect</title> |
| + </rect> |
| + </symbol> |
| + <use x="100" y="100" xlink:href="#greenSquare"></use> |
| + <use x="200" y="100" xlink:href="#blueSquare"></use> |
| + <use x="300" y="100" xlink:href="#greenSquare"> |
| + <title>Title in Use</title> |
| + </use> |
| +</svg> |
| +<script> |
| +if (!window.eventSender || !window.testRunner) |
| + test(function () { assert_unreached(); }, "Cannot run tests without eventSender and testRunner"); |
|
fs
2017/03/03 08:53:30
If you move the eventSender manipulation inside th
mrunal
2017/03/03 20:09:40
Ok, removed.
|
| + |
| +testTooltipText(125, 125, "Title in Symbol", "Tooltip title of title child under shadow root"); |
| +testTooltipText(225, 125, "", "Tooltip title without any first level title child under shadow root. Should return empty string"); |
| +testTooltipText(325, 125, "Title in Use", "Tooltip title under Use"); |
| + |
| +function testTooltipText(x, y, expectedText, description) { |
| + if (!window.eventSender || !window.testRunner) |
| + return; |
| + eventSender.dragMode = false; |
| + eventSender.mouseMoveTo(x,y); |
| + test(function () { |
| + assert_equals(testRunner.tooltipText, expectedText); |
| + }, description); |
| +} |
| +</script> |
