third_party/WebKit/LayoutTests/svg/dom/tooltip-title-with-use.html - Issue 2706583002: Fix the way <title> is read under <use> shadow tree

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/tooltip-title-with-use.html

Issue 2706583002: Fix the way <title> is read under <use> shadow tree (Closed)

Patch Set: Add testharness based test case and remove shadow tree test case Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>
	fs 2017/03/02 08:45:07 You don't need this. You don't need this. mrunal 2017/03/02 23:49:06 Done. Show quoted text On 2017/03/02 08:45:07, fs wrote: > You don't need this. Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <div id=log></div>
	fs 2017/03/02 08:45:07 Or this. Or this. mrunal 2017/03/02 23:49:07 Done. Show quoted text On 2017/03/02 08:45:07, fs wrote: > Or this. Done.
	6 <svg width="400" height="400">

	7 <symbol id="greenSquare">

	8 <title>Title in Symbol</title>

	9 <rect width="50" height="50" fill="green">

	10 <title>Title in Rect</title>

	11 </rect>

	12 </symbol>

	13 <symbol id="redSquare">
	fs 2017/03/02 08:45:07 Nit: Could you make this "blueSquare" or so instea Nit: Could you make this "blueSquare" or so instead ("red" is a common indicator of failure, so it's good to avoid using that color when it doesn't convey failure.) mrunal 2017/03/02 23:49:06 Done. Show quoted text On 2017/03/02 08:45:07, fs wrote: > Nit: Could you make this "blueSquare" or so instead ("red" is a common indicator > of failure, so it's good to avoid using that color when it doesn't convey > failure.) Done.
	14 <rect width="50" height="50" fill="red">

	15 <title>Title in Rect</title>

	16 </rect>

	17 </symbol>

	18 <use x="100" y="100" xlink:href="#greenSquare"></use>

	19 <use x="200" y="100" xlink:href="#redSquare"></use>

	20 <use x="300" y="100" xlink:href="#greenSquare">

	21 <title>Title in Use</title>

	22 </use>

	23 </svg>

	24 <script>

	25 testTooltipText(125, 125, "Title in Symbol", "Tooltip title of title child under shadow root");

	26 testTooltipText(225, 125, "", "Tooltip title without any first level title child under shadow root. Should return empty string");

	27 testTooltipText(325, 125, "Title in Use", "Tooltip title under Use");

	28

	29 function testTooltipText(x, y, expectedText, description) {

	30 eventSender.dragMode = false;
	fs 2017/03/02 08:45:07 But these two lines in the test function (this sho But these two lines in the test function (this should make the test fail more gracefully when the eventSender isn't available.) mrunal 2017/03/02 23:49:07 Not sure what you meant here but I have now added Show quoted text On 2017/03/02 08:45:07, fs wrote: > But these two lines in the test function (this should make the test fail more > gracefully when the eventSender isn't available.) Not sure what you meant here but I have now added checks for eventSender and testRunner. fs 2017/03/03 08:53:29 What I meant was to write this as: test(function( Show quoted text On 2017/03/02 at 23:49:07, mrunal wrote: > On 2017/03/02 08:45:07, fs wrote: > > But these two lines in the test function (this should make the test fail more > > gracefully when the eventSender isn't available.) > > Not sure what you meant here but I have now added checks for eventSender and testRunner. What I meant was to write this as: test(function() { eventSender.dragMode = false; ... }, description); instead, since these actions are a part of the test. (And since these will throw if eventSender isn't available it's good to have them within the test() body, since the test harness will catch and report that.) Not a huge deal, but preferable.
	31 eventSender.mouseMoveTo(x,y);

	32 test(function () {

	33 assert_equals(testRunner.tooltipText, expectedText);

	34 }, description);

	35 }

	36 </script>

	37 </body>
	fs 2017/03/02 08:45:07 Since <body> isn't needed, neither is this. Since <body> isn't needed, neither is this. mrunal 2017/03/02 23:49:07 Done. Show quoted text On 2017/03/02 08:45:07, fs wrote: > Since <body> isn't needed, neither is this. Done.
OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGUseElement.h » ('j') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('J')