third_party/WebKit/LayoutTests/svg/dom/title-in-shadow-tree-without-any-title-in-use.html - Issue 2706583002: Fix the way <title> is read under <use> shadow tree

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/title-in-shadow-tree-without-any-title-in-use.html

Issue 2706583002: Fix the way <title> is read under <use> shadow tree (Closed)

Patch Set: Add layout test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/dom/title-in-shadow-tree-without-any-title-in-use-expected.txt » ('j') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <template id="template">

	3 <svg width="100" height="100">

	4 <symbol id="greenSquare">

	5 <title>PASS: This text should appear as a tooltip.</title>

	6 <rect width="50" height="50" fill="green">

	7 <title>FAIL: This text should not appear as a tooltip.</title>

	8 </rect>

	9 </symbol>

	10 <use x="50" y="50" xlink:href="#greenSquare">

	11 </use>
	fs 2017/03/01 09:29:05 Nit: Can move this to the previous line. Nit: Can move this to the previous line.
	12 </svg>

	13 </template>

	14

	15 <script>

	16 document.body.createShadowRoot().appendChild(template.content.cloneNode(true ));
	fs 2017/03/01 09:29:05 Should test this as a regular <use> (outside of an Should test this as a regular <use> (outside of an shadow explicit), which is what the bug is about. Having a test like this is a good bonus though.
	17

	18 onload = function() {

	19 if (window.eventSender) {

	20 eventSender.dragMode = false;

	21 eventSender.mouseMoveTo(75, 75);

	22 document.write(testRunner.tooltipText);

	23 if (window.testRunner)

	24 testRunner.dumpAsText();
	fs 2017/03/01 09:29:05 It should be possible (and preferable) to write th It should be possible (and preferable) to write this as a testharness.js test. mrunal 2017/03/02 03:37:43 Done. I have removed this test and added testharne Show quoted text On 2017/03/01 09:29:05, fs wrote: > It should be possible (and preferable) to write this as a testharness.js test. Done. I have removed this test and added testharness.js test now. I adapted this from title-in-shadow-tree.html test thinking it was testing similar things but looks like it is different. BTW, I also saw third_party/WebKit/ManualTests/svg-tooltip.svg as part of manual tests which should also cover this but I am not sure how Manual Tests are run. fs 2017/03/02 08:45:07 ManualTests are manually, so I guess in general th Show quoted text On 2017/03/02 at 03:37:43, mrunal wrote: > On 2017/03/01 09:29:05, fs wrote: > > It should be possible (and preferable) to write this as a testharness.js test. > > Done. I have removed this test and added testharness.js test now. I adapted this from title-in-shadow-tree.html test thinking it was testing similar things but looks like it is different. > BTW, I also saw third_party/WebKit/ManualTests/svg-tooltip.svg as part of manual tests which should also cover this but I am not sure how Manual Tests are run. ManualTests are manually, so I guess in general they aren't run at all =). (And hence they are of lesser value in general...)
	25 }

	26 }

	27 </script>

	28

	29 FAIL: Test did not run.

OLD	NEW