Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: content/browser/webrtc/webrtc_browsertest.cc

Issue 2706563003: Create the API that returns the RTCConfiguration of the PeerConnection.
Patch Set: rebaselining Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webrtc/webrtc_browsertest.cc
diff --git a/content/browser/webrtc/webrtc_browsertest.cc b/content/browser/webrtc/webrtc_browsertest.cc
index cc0d2556448fdfae823754e23fa2691b41f3a7bf..2f84854fe0129534711ac7726ca1f97339a0d2ed 100644
--- a/content/browser/webrtc/webrtc_browsertest.cc
+++ b/content/browser/webrtc/webrtc_browsertest.cc
@@ -49,7 +49,8 @@ class MAYBE_WebRtcBrowserTest : public WebRtcContentBrowserTestBase {
void SetConfigurationTest(const std::string& javascript) {
// This doesn't actually "make a call", it just loads the page, executes
// the javascript and waits for "OK".
- MakeTypicalCall(javascript, "/media/peerconnection-setConfiguration.html");
+ MakeTypicalCall(javascript,
+ "/media/peerconnection-setAndGetConfiguration.html");
}
};
@@ -209,9 +210,9 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CallInsideIframe) {
}
// Tests that SetConfiguration succeeds and triggers an ICE restart on the next
-// offer as described by JSEP.
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, SetConfiguration) {
- SetConfigurationTest("testSetConfiguration();");
+// offer as described by JSEP. Also tests that GetConfiguration() succeeds.
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, SetAndGetConfiguration) {
+ SetConfigurationTest("testSetAndGetConfiguration();");
}
// Tests the error conditions of SetConfiguration as described by webrtc-pc.

Powered by Google App Engine
This is Rietveld 408576698