Remove force-update when visual rects change

Remove force-update when visual rects change.

This code was added in https://codereview.chromium.org/1368163002, but
subsequently https://codereview.chromium.org/2668823002 landed, which
does the same thing and in a more targeted way.

BUG=490725, 692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[chrishtr, 2017-02-17 21:38:59]

Description was changed from

==========
none

BUG=
==========

to

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-17 21:40:54]

Description was changed from

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove force-update when visual rects change.

This code was added in https://codereview.chromium.org/1368163002, but
subsequently https://codereview.chromium.org/2668823002 landed, which
does the same thing and in a more targeted way.

BUG=490725,692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-17 21:41:00]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 21:41:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-02-17 23:02:07]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2017-02-17 23:02:32]

I *think* this is correct, but please tell me if I'm missing something.

[commit-bot: I haz the power, 2017-02-17 23:43:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:43:49]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Xianzhu, 2017-02-21 19:31:00]

https://codereview.chromium.org/2706553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (left):

https://codereview.chromium.org/2706553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:447:
PaintInvalidatorContext::ForcedSubtreeInvalidationRectUpdate;
We still need to set the flag on ancestor clip change, now in PrePaintTreeWalk.

This patch fails with a modified version of
paint/invalidation/clip-unclip-and-change.html. I create a new patch based on
this CL. It includes the modified test case and fixes the issue:
https://codereview.chromium.org/2702883002/.

[chrishtr, 2017-02-27 21:15:36]

https://codereview.chromium.org/2706553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (left):

https://codereview.chromium.org/2706553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:447:
PaintInvalidatorContext::ForcedSubtreeInvalidationRectUpdate;
On 2017/02/21 at 19:31:00, Xianzhu wrote:
> We still need to set the flag on ancestor clip change, now in
PrePaintTreeWalk.
> 
> This patch fails with a modified version of
paint/invalidation/clip-unclip-and-change.html. I create a new patch based on
this CL. It includes the modified test case and fixes the issue:
https://codereview.chromium.org/2702883002/.

Is this test exhibiting a case where the paint invalidator context
was not properly updated for the item which changes its clip?

[Xianzhu, 2017-02-27 21:40:02]

On 2017/02/27 21:15:36, chrishtr wrote:
>
https://codereview.chromium.org/2706553002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (left):
> 
>
https://codereview.chromium.org/2706553002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:447:
> PaintInvalidatorContext::ForcedSubtreeInvalidationRectUpdate;
> On 2017/02/21 at 19:31:00, Xianzhu wrote:
> > We still need to set the flag on ancestor clip change, now in
> PrePaintTreeWalk.
> > 
> > This patch fails with a modified version of
> paint/invalidation/clip-unclip-and-change.html. I create a new patch based on
> this CL. It includes the modified test case and fixes the issue:
> https://codereview.chromium.org/2702883002/.
> 
> Is this test exhibiting a case where the paint invalidator context
> was not properly updated for the item which changes its clip?

Yes. The failed tests listed in
https://codereview.chromium.org/2702883002/#msg17 exhibits more cases.