Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: content/renderer/presentation/presentation_dispatcher_unittest.cc

Issue 2706463002: [Presentation API] Mojo typemap for content::PresentationConnectionMessage (Closed)
Patch Set: Fix compile error after rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/presentation/presentation_dispatcher_unittest.cc
diff --git a/content/renderer/presentation/presentation_dispatcher_unittest.cc b/content/renderer/presentation/presentation_dispatcher_unittest.cc
index 732b161a06a8e6df3e8d38929f9a38fbd9233b0c..af8ecb5501ec357d1ea8fc0920afd47314cb78a8 100644
--- a/content/renderer/presentation/presentation_dispatcher_unittest.cc
+++ b/content/renderer/presentation/presentation_dispatcher_unittest.cc
@@ -6,6 +6,7 @@
#include <utility>
#include "base/run_loop.h"
+#include "content/public/common/presentation_connection_message.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/renderer/presentation/presentation_connection_proxy.h"
#include "content/renderer/presentation/presentation_dispatcher.h"
@@ -34,8 +35,6 @@ using blink::WebVector;
using blink::mojom::PresentationConnection;
using blink::mojom::PresentationService;
using blink::mojom::PresentationServiceClientPtr;
-using blink::mojom::ConnectionMessage;
-using blink::mojom::ConnectionMessagePtr;
// TODO(crbug.com/576808): Add test cases for the following:
// - State changes
@@ -75,7 +74,6 @@ class MockPresentationService : public PresentationService {
void(const std::vector<GURL>& presentation_urls,
const base::Optional<std::string>& presentation_id,
const JoinSessionCallback& callback));
-
MOCK_METHOD2(CloseConnection,
void(const GURL& presentation_url,
const std::string& presentation_id));
@@ -103,12 +101,13 @@ class TestPresentationConnectionProxy : public PresentationConnectionProxy {
TestPresentationConnectionProxy(blink::WebPresentationConnection* connection)
: PresentationConnectionProxy(connection) {}
- void SendConnectionMessage(blink::mojom::ConnectionMessagePtr session_message,
- const OnMessageCallback& callback) const override {
- SendConnectionMessageInternal(session_message.get(), callback);
+ // PresentationConnectionMessage is move-only.
+ void SendConnectionMessage(PresentationConnectionMessage message,
+ const OnMessageCallback& cb) const {
+ SendConnectionMessageInternal(message, cb);
}
MOCK_CONST_METHOD2(SendConnectionMessageInternal,
- void(blink::mojom::ConnectionMessage*,
+ void(const PresentationConnectionMessage&,
const OnMessageCallback&));
MOCK_CONST_METHOD0(close, void());
};
@@ -413,31 +412,35 @@ TEST_F(PresentationDispatcherTest, TestSendString) {
TestPresentationConnection connection;
TestPresentationConnectionProxy connection_proxy(&connection);
+ PresentationConnectionMessage expected_message(message.utf8());
+
base::RunLoop run_loop;
EXPECT_CALL(connection_proxy, SendConnectionMessageInternal(_, _))
- .WillOnce(Invoke([&message](ConnectionMessage* session_message,
- const OnMessageCallback& callback) {
- EXPECT_EQ(blink::mojom::PresentationMessageType::TEXT,
- session_message->type);
- EXPECT_EQ(message.utf8(), session_message->message.value());
+ .WillOnce(Invoke([&expected_message](
+ const PresentationConnectionMessage& message_request,
+ const OnMessageCallback& callback) {
+ EXPECT_EQ(message_request, expected_message);
+ callback.Run(true);
}));
+
dispatcher_.sendString(url1_, presentation_id_, message, &connection_proxy);
run_loop.RunUntilIdle();
}
TEST_F(PresentationDispatcherTest, TestSendArrayBuffer) {
+ std::vector<uint8_t> data(array_buffer_data(),
+ array_buffer_data() + array_buffer_.byteLength());
TestPresentationConnection connection;
TestPresentationConnectionProxy connection_proxy(&connection);
+ PresentationConnectionMessage expected_message(data);
base::RunLoop run_loop;
EXPECT_CALL(connection_proxy, SendConnectionMessageInternal(_, _))
- .WillOnce(Invoke([this](ConnectionMessage* message_request,
- const OnMessageCallback& callback) {
- std::vector<uint8_t> data(
- array_buffer_data(),
- array_buffer_data() + array_buffer_.byteLength());
- EXPECT_TRUE(message_request->data.has_value());
- EXPECT_EQ(data, message_request->data.value());
+ .WillOnce(Invoke([&expected_message](
+ const PresentationConnectionMessage& message_request,
+ const OnMessageCallback& callback) {
+ EXPECT_EQ(message_request, expected_message);
+ callback.Run(true);
}));
dispatcher_.sendArrayBuffer(url1_, presentation_id_, array_buffer_data(),
array_buffer_.byteLength(), &connection_proxy);
@@ -445,18 +448,18 @@ TEST_F(PresentationDispatcherTest, TestSendArrayBuffer) {
}
TEST_F(PresentationDispatcherTest, TestSendBlobData) {
+ std::vector<uint8_t> data(array_buffer_data(),
+ array_buffer_data() + array_buffer_.byteLength());
TestPresentationConnection connection;
TestPresentationConnectionProxy connection_proxy(&connection);
+ PresentationConnectionMessage expected_message(data);
base::RunLoop run_loop;
EXPECT_CALL(connection_proxy, SendConnectionMessageInternal(_, _))
- .WillOnce(Invoke([this](ConnectionMessage* message_request,
- const OnMessageCallback& callback) {
- std::vector<uint8_t> data(
- array_buffer_data(),
- array_buffer_data() + array_buffer_.byteLength());
- EXPECT_TRUE(message_request->data.has_value());
- EXPECT_EQ(data, message_request->data.value());
+ .WillOnce(Invoke([&expected_message](
+ const PresentationConnectionMessage& message_request,
+ const OnMessageCallback& callback) {
+ EXPECT_EQ(message_request, expected_message);
callback.Run(true);
}));
dispatcher_.sendBlobData(url1_, presentation_id_, array_buffer_data(),

Powered by Google App Engine
This is Rietveld 408576698