Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1798)

Unified Diff: chrome/browser/media/router/browser_presentation_connection_proxy.cc

Issue 2706463002: [Presentation API] Mojo typemap for content::PresentationConnectionMessage (Closed)
Patch Set: Fix compile error after rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/browser_presentation_connection_proxy.cc
diff --git a/chrome/browser/media/router/browser_presentation_connection_proxy.cc b/chrome/browser/media/router/browser_presentation_connection_proxy.cc
index 3dead0d453d3692436d4d4c1aeb4fa125efff125..1cdcca1be3c66156e3d15dd4e82422a5a2012eaa 100644
--- a/chrome/browser/media/router/browser_presentation_connection_proxy.cc
+++ b/chrome/browser/media/router/browser_presentation_connection_proxy.cc
@@ -4,54 +4,11 @@
#include "chrome/browser/media/router/browser_presentation_connection_proxy.h"
-#include "chrome/browser/media/router/media_router.h"
-#include "content/public/common/presentation_constants.h"
-
-namespace {
-
-// TODO(crbug.com/632623): remove this function when we finish typemaps for
-// presentation.mojom.
-std::unique_ptr<content::PresentationConnectionMessage>
-PresentationConnectionMessageFromMojo(
- blink::mojom::ConnectionMessagePtr input) {
- std::unique_ptr<content::PresentationConnectionMessage> output;
- if (input.is_null())
- return output;
+#include <vector>
- switch (input->type) {
- case blink::mojom::PresentationMessageType::TEXT: {
- // Return nullptr content::PresentationSessionMessage if invalid (unset
- // |message|, set |data|, or size too large).
- if (input->data || !input->message ||
- input->message->size() >
- content::kMaxPresentationConnectionMessageSize)
- return output;
-
- output.reset(new content::PresentationConnectionMessage(
- content::PresentationMessageType::TEXT));
- output->message = std::move(input->message.value());
- return output;
- }
- case blink::mojom::PresentationMessageType::BINARY: {
- // Return nullptr content::PresentationSessionMessage if invalid (unset
- // |data|, set |message|, or size too large).
- if (!input->data || input->message ||
- input->data->size() > content::kMaxPresentationConnectionMessageSize)
- return output;
-
- output.reset(new content::PresentationConnectionMessage(
- content::PresentationMessageType::BINARY));
- output->data.reset(
- new std::vector<uint8_t>(std::move(input->data.value())));
- return output;
- }
- }
+#include "base/memory/ptr_util.h"
- NOTREACHED() << "Invalid presentation message type " << input->type;
- return output;
-}
-
-} // namespace
+#include "chrome/browser/media/router/media_router.h"
namespace media_router {
@@ -75,19 +32,17 @@ BrowserPresentationConnectionProxy::BrowserPresentationConnectionProxy(
BrowserPresentationConnectionProxy::~BrowserPresentationConnectionProxy() {}
void BrowserPresentationConnectionProxy::OnMessage(
- blink::mojom::ConnectionMessagePtr connection_message,
+ content::PresentationConnectionMessage message,
const OnMessageCallback& on_message_callback) {
DVLOG(2) << "BrowserPresentationConnectionProxy::OnMessage";
- DCHECK(!connection_message.is_null());
-
- auto message =
- PresentationConnectionMessageFromMojo(std::move(connection_message));
-
- if (message->is_binary()) {
- router_->SendRouteBinaryMessage(route_id_, std::move(message->data),
- on_message_callback);
+ if (message.is_binary()) {
+ router_->SendRouteBinaryMessage(
+ route_id_,
+ base::MakeUnique<std::vector<uint8_t>>(std::move(message.data.value())),
+ on_message_callback);
} else {
- router_->SendRouteMessage(route_id_, message->message, on_message_callback);
+ router_->SendRouteMessage(route_id_, message.message.value(),
+ on_message_callback);
}
}

Powered by Google App Engine
This is Rietveld 408576698