Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4086)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

Issue 2706463002: [Presentation API] Mojo typemap for content::PresentationConnectionMessage (Closed)
Patch Set: Respond to dcheng@ comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
index 45ed33577bc67a3e8bdaa7d4f1b550ea64c1e3ff..fa17218e680648922cf603bb1ef706e4c24503ef 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
@@ -889,26 +889,25 @@ TEST_F(MediaRouterMojoImplTest, SendRouteMessage) {
}
TEST_F(MediaRouterMojoImplTest, SendRouteBinaryMessage) {
- std::unique_ptr<std::vector<uint8_t>> expected_binary_data(
- new std::vector<uint8_t>(kBinaryMessage,
- kBinaryMessage + arraysize(kBinaryMessage)));
+ std::vector<uint8_t> expected_binary_data(
+ kBinaryMessage, kBinaryMessage + arraysize(kBinaryMessage));
EXPECT_CALL(mock_media_route_provider_,
- SendRouteBinaryMessageInternal(kRouteId, _, _))
- .WillOnce(Invoke([](
- const MediaRoute::Id& route_id, const std::vector<uint8_t>& data,
- const mojom::MediaRouteProvider::SendRouteMessageCallback& cb) {
- EXPECT_EQ(
- 0, memcmp(kBinaryMessage, &(data[0]), arraysize(kBinaryMessage)));
- cb.Run(true);
- }));
+ SendRouteBinaryMessage(kRouteId, _, _))
+ .WillOnce(Invoke(
+ [](const MediaRoute::Id& route_id, const std::vector<uint8_t>& data,
+ const mojom::MediaRouteProvider::SendRouteMessageCallback& cb) {
+ EXPECT_EQ(0, memcmp(kBinaryMessage, &(data[0]),
+ arraysize(kBinaryMessage)));
+ cb.Run(true);
+ }));
base::RunLoop run_loop;
SendMessageCallbackHandler handler;
EXPECT_CALL(handler, Invoke(true))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
router()->SendRouteBinaryMessage(
- kRouteId, std::move(expected_binary_data),
+ kRouteId, expected_binary_data,
base::Bind(&SendMessageCallbackHandler::Invoke,
base::Unretained(&handler)));
run_loop.Run();

Powered by Google App Engine
This is Rietveld 408576698