Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Issue 2706463002: [Presentation API] Mojo typemap for content::PresentationConnectionMessage (Closed)
Patch Set: Remove TODO Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/presentation/presentation.mojom
diff --git a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
index 7df477f38143eb50375a814f14895c5fa3a0c2ad..9f8a36d217ba104064e94592674cdb3737be20c4 100644
--- a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
+++ b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
@@ -39,19 +39,9 @@ struct PresentationError {
string message;
};
-enum PresentationMessageType {
- TEXT,
- BINARY,
-};
-
-struct ConnectionMessage {
- PresentationMessageType type;
- // Used when message type is TEXT.
- string? message;
- // Used when message type is BINARY.
- // TODO(lethalantidote): Make this a mojo union.
- // See https://crbug.com/632623.
- array<uint8>? data;
+union PresentationConnectionMessage {
+ string message;
+ array<uint8> data;
};
interface PresentationConnection {
@@ -59,7 +49,7 @@ interface PresentationConnection {
// PresentationConnection.Send(). http://crbug.com/658474
// Called when a message is sent by the target connection.
- OnMessage(ConnectionMessage message) => (bool success);
+ OnMessage(PresentationConnectionMessage message) => (bool success);
// Called when target connection notifies connection state change.
DidChangeState(PresentationConnectionState state);
@@ -114,7 +104,6 @@ interface PresentationService {
PresentationConnection& receiver_connection_request);
//////////////////////////////////////////////////////////////////////////////
-
// Called when close() is called by the frame.
CloseConnection(url.mojom.Url presentation_url, string presentation_id);
@@ -162,7 +151,7 @@ interface PresentationServiceClient {
// See PresentationService::ListenForConnectionMessages.
OnConnectionMessagesReceived(PresentationSessionInfo sessionInfo,
- array<ConnectionMessage> messages);
+ array<PresentationConnectionMessage> messages);
// Called on a presentation receiver when presentation connection is available
// from the controlling page.

Powered by Google App Engine
This is Rietveld 408576698