Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Unified Diff: chrome/browser/media/cast_remoting_connector_unittest.cc

Issue 2706463002: [Presentation API] Mojo typemap for content::PresentationConnectionMessage (Closed)
Patch Set: Remove TODO Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/cast_remoting_connector_unittest.cc
diff --git a/chrome/browser/media/cast_remoting_connector_unittest.cc b/chrome/browser/media/cast_remoting_connector_unittest.cc
index bf613be2dea95248d871206a558156745e146f31..523c40e2b75f4dc15829bb0c0c75c7a08cc2aa13 100644
--- a/chrome/browser/media/cast_remoting_connector_unittest.cc
+++ b/chrome/browser/media/cast_remoting_connector_unittest.cc
@@ -165,7 +165,7 @@ class FakeMediaRouter : public media_router::MockMediaRouter {
}
void SendRouteMessage(const MediaRoute::Id& route_id,
- const std::string& text,
+ std::string text,
const SendRouteMessageCallback& callback) final {
EXPECT_EQ(message_observer_->route_id(), route_id);
ASSERT_FALSE(callback.is_null());
@@ -175,16 +175,14 @@ class FakeMediaRouter : public media_router::MockMediaRouter {
outbound_messages_.push_back(std::make_pair(message, callback));
}
- void SendRouteBinaryMessage(
- const MediaRoute::Id& route_id,
- std::unique_ptr<std::vector<uint8_t>> data,
- const SendRouteMessageCallback& callback) final {
+ void SendRouteBinaryMessage(const MediaRoute::Id& route_id,
+ std::vector<uint8_t> data,
+ const SendRouteMessageCallback& callback) final {
EXPECT_EQ(message_observer_->route_id(), route_id);
- ASSERT_TRUE(!!data);
ASSERT_FALSE(callback.is_null());
RouteMessage message;
message.type = RouteMessage::BINARY;
- message.binary = std::move(*data);
+ message.binary = data;
outbound_messages_.push_back(std::make_pair(message, callback));
}

Powered by Google App Engine
This is Rietveld 408576698