Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: content/public/browser/presentation_service_delegate.h

Issue 2706463002: [Presentation API] Mojo typemap for content::PresentationConnectionMessage (Closed)
Patch Set: Fix compile error in presentation_connection_message Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/presentation_service_delegate.h
diff --git a/content/public/browser/presentation_service_delegate.h b/content/public/browser/presentation_service_delegate.h
index 5ac36c1a8dde3136ed6d54e1ebf4e2b7a2e93c09..4f2cd34252c5ca258cade9773ac12d7b55f9f925 100644
--- a/content/public/browser/presentation_service_delegate.h
+++ b/content/public/browser/presentation_service_delegate.h
@@ -28,11 +28,8 @@ using PresentationSessionErrorCallback =
base::Callback<void(const PresentationError&)>;
// Param #0: a vector of messages that are received.
Avi (use Gerrit) 2017/02/24 04:08:51 Drop the "#0" now that there's only one?
mark a. foltz 2017/02/27 23:25:14 Done.
-// Param #1: tells the callback handler that it may reuse strings or buffers
-// in the messages contained within param #0.
using PresentationConnectionMessageCallback = base::Callback<void(
- const std::vector<std::unique_ptr<content::PresentationConnectionMessage>>&,
- bool)>;
+ const std::vector<content::PresentationConnectionMessage>&)>;
struct PresentationConnectionStateChangeInfo {
explicit PresentationConnectionStateChangeInfo(
@@ -200,12 +197,11 @@ class CONTENT_EXPORT ControllerPresentationServiceDelegate
// |message|: The message to send. The embedder takes ownership of |message|.
// Must not be null.
// |send_message_cb|: Invoked after handling the send message request.
- virtual void SendMessage(
- int render_process_id,
- int render_frame_id,
- const content::PresentationSessionInfo& session,
- std::unique_ptr<PresentationConnectionMessage> message,
- const SendMessageCallback& send_message_cb) = 0;
+ virtual void SendMessage(int render_process_id,
+ int render_frame_id,
+ const content::PresentationSessionInfo& session,
+ const PresentationConnectionMessage& message,
+ const SendMessageCallback& send_message_cb) = 0;
// Continuously listen for state changes for a PresentationConnection in a
// frame.

Powered by Google App Engine
This is Rietveld 408576698