[Presentation API] Mojo typemap for content::PresentationConnectionMessage

chrome/browser/media/cast_remoting_connector_unittest.cc

Index: chrome/browser/media/cast_remoting_connector_unittest.cc
diff --git a/chrome/browser/media/cast_remoting_connector_unittest.cc b/chrome/browser/media/cast_remoting_connector_unittest.cc
index bf613be2dea95248d871206a558156745e146f31..3fbcf0c84904da8e49dc080a8592b97396ecc353 100644
--- a/chrome/browser/media/cast_remoting_connector_unittest.cc
+++ b/chrome/browser/media/cast_remoting_connector_unittest.cc
@@ -175,16 +175,14 @@ class FakeMediaRouter : public media_router::MockMediaRouter {
     outbound_messages_.push_back(std::make_pair(message, callback));
   }
 
-  void SendRouteBinaryMessage(
-      const MediaRoute::Id& route_id,
-      std::unique_ptr<std::vector<uint8_t>> data,
-      const SendRouteMessageCallback& callback) final {
+  void SendRouteBinaryMessage(const MediaRoute::Id& route_id,
+                              const std::vector<uint8_t>& data,
+                              const SendRouteMessageCallback& callback) final {
     EXPECT_EQ(message_observer_->route_id(), route_id);
-    ASSERT_TRUE(!!data);
     ASSERT_FALSE(callback.is_null());
     RouteMessage message;
     message.type = RouteMessage::BINARY;
-    message.binary = std::move(*data);
+    message.binary = std::move(data);

[imcheng, 2017/02/25 01:08:40]

Since data is a const ref, doesn't that mean we are still making a copy here?

[dcheng, 2017/02/25 07:17:27]

Yes =)

[mark a. foltz, 2017/02/27 23:25:14]

Done

     outbound_messages_.push_back(std::make_pair(message, callback));
   }