third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp - Issue 2706453002: [Presentation API] return valid WebPresentationConnection object in PresentationReceiver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp

Issue 2706453002: [Presentation API] return valid WebPresentationConnection object in PresentationReceiver (Closed)

Patch Set: resolve code review comments from Derek Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js ('k') | third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp

index bbefd948fc6eee8837c51d4f2f38aa304c359274..14aea2196ba1860d7528fa487ad86f398c4263c5 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp

@@ -49,14 +49,15 @@ WebPresentationConnection* PresentationReceiver::onReceiverConnectionAvailable(

// receiver.connectionList property not accessed

if (!m_connectionListProperty)

- return nullptr;

+ return connection;

if (m_connectionListProperty->getState() ==

- ScriptPromisePropertyBase::Pending)

+ ScriptPromisePropertyBase::Pending) {

m_connectionListProperty->resolve(m_connectionList);

- else if (m_connectionListProperty->getState() ==

- ScriptPromisePropertyBase::Resolved)

+ } else if (m_connectionListProperty->getState() ==

+ ScriptPromisePropertyBase::Resolved) {

m_connectionList->dispatchConnectionAvailableEvent(connection);

+ }

return connection;

}