third_party/WebKit/LayoutTests/presentation/presentation-onreceiverconnection.html - Issue 2706453002: [Presentation API] return valid WebPresentationConnection object in PresentationReceiver

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/presentation/presentation-onreceiverconnection.html

Issue 2706453002: [Presentation API] return valid WebPresentationConnection object in PresentationReceiver (Closed)

Patch Set: add layout test for receiver.connectionList Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js » ('j') | third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script src="../resources/mojo-helpers.js"></script>

	7 <script src="resources/presentation-service-mock.js"></script>

	8 <script>

	9

	10 async_test(t => {

	11 internals.settings.setPresentationReceiver(true);

	12 t.add_cleanup(_ => { internals.settings.setPresentationReceiver(false); });

	13

	14 presentationServiceMock.then(mockService => {

	15 // Invoke mockService.setClient().

	16 var receiver = navigator.presentation.receiver;
	mark a. foltz 2017/02/21 17:47:38 s/var/const/ s/var/const/ zhaobin 2017/02/21 19:11:38 Done. Show quoted text On 2017/02/21 17:47:38, mark a. foltz wrote: > s/var/const/ Done.
	17

	18 // Make sure it is invoked after calling setClient().

	19 setTimeout(() => {
	mark a. foltz 2017/02/21 17:47:38 Does the rest of the test need to be in an event h Does the rest of the test need to be in an event handler? The line above to get the receiver object is synchronous. zhaobin 2017/02/21 19:11:38 Yes, put them in an event handler to make sure thi Show quoted text On 2017/02/21 17:47:38, mark a. foltz wrote: > Does the rest of the test need to be in an event handler? The line above to get > the receiver object is synchronous. Yes, put them in an event handler to make sure this.client_ is set when calling mockService.onReceiverConnectionAvailable(). navigator.presentation.receiver invokes mockService.setClient() (mojo API of PSImpl) to set this.client_ of mockService. It is a mojo call and has some delays. If there is no setTimeout(), this.client_ will not be set when calling mockService.onReceiverConnectionAvailable().
	20 const url = 'http://example.com/a.html';

	21 const id = 'fakeSessionId';

	22 mockService.onReceiverConnectionAvailable(url, id);

	23

	24 receiver.connectionList.then(

	25 t.step_func_done(list => {

	26 assert_equals(list.connections.length, 1);

	27 list.connections.map(connection => {
	mark a. foltz 2017/02/21 17:47:38 Since the length is 1, you could just write asser Since the length is 1, you could just write assert_equals(list.connections[0].url, url); etc. Not a big deal :) zhaobin 2017/02/21 19:11:38 Done. Show quoted text On 2017/02/21 17:47:38, mark a. foltz wrote: > Since the length is 1, you could just write > > assert_equals(list.connections[0].url, url); > etc. > > Not a big deal :) Done.
	28 assert_equals(connection.url, url);

	29 assert_equals(connection.id, id);

	30 });

	31 }));

	32 });

	33 });

	34 }, "Test presetnation.receiver.connectionList resolves with incoming connection. ");

	35

	36 </script>

	37 </body>

	38 </html>

OLD	NEW