Use GridLayout for DialogClientView's button row.

ui/views/window/dialog_client_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WINDOW_DIALOG_CLIENT_VIEW_H_
 #define UI_VIEWS_WINDOW_DIALOG_CLIENT_VIEW_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "ui/base/ui_base_types.h"
@@ skipping 33 matching lines @@
   // Update the dialog buttons to match the dialog's delegate.
   void UpdateDialogButtons();
 
   // ClientView implementation:
   bool CanClose() override;
   DialogClientView* AsDialogClientView() override;
   const DialogClientView* AsDialogClientView() const override;
 
   // View implementation:
   gfx::Size GetPreferredSize() const override;
+  gfx::Size GetMinimumSize() const override;
+  gfx::Size GetMaximumSize() const override;
+
   void Layout() override;
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
   void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) override;
   void OnNativeThemeChanged(const ui::NativeTheme* theme) override;
 
   // ButtonListener implementation:
   void ButtonPressed(Button* sender, const ui::Event& event) override;
 
   void set_button_row_insets(const gfx::Insets& insets) {
     button_row_insets_ = insets;
   }
 
   void set_minimum_size(const gfx::Size& size) { minimum_size_ = size; }
 
  private:
-  bool has_dialog_buttons() const { return ok_button_ || cancel_button_; }
+  class ButtonRowContainer;
 
   // Returns the DialogDelegate for the window.
   DialogDelegate* GetDialogDelegate() const;
 
   // View implementation.
   void ChildPreferredSizeChanged(View* child) override;
   void ChildVisibilityChanged(View* child) override;
 
-  // Create a dialog button of the appropriate type.
-  LabelButton* CreateDialogButton(ui::DialogButton type);
-
-  // Update |button|'s text and enabled state according to the delegate's state.
-  void UpdateButton(LabelButton* button, ui::DialogButton type);
-
-  // Returns the height of the buttons.
-  int GetButtonHeight() const;
-
-  // Returns the height of the extra view.
-  int GetExtraViewHeight() const;
-
-  // Returns the height of the row containing the buttons and the extra view.
-  int GetButtonsAndExtraViewRowHeight() const;
-
-  // Returns the insets for the buttons and extra view, including the vertical
-  // padding between them and the contents view.
-  gfx::Insets GetButtonRowInsets() const;
-
-  // Sets up the focus chain for the child views. This is required since the
-  // delegate may choose to add/remove views at any time.
-  void SetupFocusChain();
+  // Update the dialog button |member| according to the DialogDelegate.

[Peter Kasting, 2017/02/25 06:04:08]

Nit: Updates

Updates like how?

Do you need to say what |type| is used for?

[tapted, 2017/02/27 10:04:19]

Done.

+  void UpdateDialogButton(LabelButton** member, ui::DialogButton type);
 
   // Returns the spacing between the extra view and the ok/cancel buttons. 0 if
   // no extra view. Otherwise uses GetExtraViewPadding() or the default padding.
   int GetExtraViewSpacing() const;
 
+  // Returns the 0-3 Views in the order they should appear in the button row.

[Peter Kasting, 2017/02/25 06:04:08]

Nit: the 0-3 Views -> any button views

(Seems best not to explicitly say "0-3" here even though in practice that's
true.)

[tapted, 2017/02/27 10:04:19]

Done.

+  std::vector<View*> ButtonRowViews();

[Peter Kasting, 2017/02/25 06:04:08]

Nit: GetButtonRowViews()?

[tapted, 2017/02/27 10:04:19]

Done.

+
+  // Installs and configures the LayoutManager for |button_row_container_|.
+  void SetupLayout();
+
   // Creates or deletes any buttons that are required. Updates data members.
+  // All buttons are removed from the hierarchy to be added by the layout.

[Peter Kasting, 2017/02/25 06:04:08]

Nit: I don't really understand this sentence.  Not enough context without
explicitly reading the code.

[tapted, 2017/02/27 10:04:19]

Changed to "After calling this, no button row Views will be in the view
hierarchy."

[Peter Kasting, 2017/02/28 03:33:23]

Is that accurate, though?  Maybe you mean "...any necessary button row Views
will be children of |button_row_container_| rather than |this|."?  (They're
still in the hierarchy in that case, just indirectly.)

[tapted, 2017/02/28 06:52:42]

Nah, in this case SetupLayout() is relying on SetupViews() to leave everything
out of the view heirarchy, so it can add them all to the Layout (GridLayout
always adds the child view to the layout host as well as adding the view to the
layout, and DCHECKs if you try it any other way).

(note that only SetupLayout() invokes SetupViews() -- it could all just be
inlined there, but functional decomposition is nice too :).

   void SetupViews();
 
   // How much to inset the button row.
   gfx::Insets button_row_insets_;
 
   // The minimum size of this dialog, regardless of the size of its content
   // view.
   gfx::Size minimum_size_;
 
   // The dialog buttons.
   LabelButton* ok_button_ = nullptr;
   LabelButton* cancel_button_ = nullptr;
 
   // The extra view shown in the row of buttons; may be NULL.
   View* extra_view_ = nullptr;
 
+  // Container view for the button row.
+  ButtonRowContainer* button_row_container_ = nullptr;
+
   // True if we've notified the delegate the window is closing and the delegate
   // allowed the close. In some situations it's possible to get two closes (see
   // http://crbug.com/71940). This is used to avoid notifying the delegate
   // twice, which can have bad consequences.
   bool delegate_allowed_close_ = false;
 
+  // Prevents ViewHierarchyChanged() from clearing out data members.

[Peter Kasting, 2017/02/25 06:04:08]

Nit: "When true, ..."

[tapted, 2017/02/27 10:04:19]

Done.

+  bool in_setup_views_ = false;

[Peter Kasting, 2017/02/25 06:04:08]

Nit: Seems like this should be named by what we want it do (e.g.
|preserve_data_members_|) instead of where it's set.

[tapted, 2017/02/27 10:04:19]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(DialogClientView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WINDOW_DIALOG_CLIENT_VIEW_H_