Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java

Issue 2706403014: Add Android implementation of navigator.getInstalledRelatedApps. (Closed)
Patch Set: Respond to review (importantly, getting the URL on every request, not caching). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 package org.chromium.content.browser.installedapp;
6
7 import org.chromium.base.ContextUtils;
8 import org.chromium.content_public.browser.RenderFrameHost;
9 import org.chromium.installedapp.mojom.InstalledAppProvider;
10 import org.chromium.services.service_manager.InterfaceFactory;
11
12 import java.net.URI;
13 import java.net.URISyntaxException;
14
15 /** Factory to create instances of the InstalledAppProvider Mojo service. */
16 public class InstalledAppProviderFactory implements InterfaceFactory<InstalledAp pProvider> {
17 private final PageUrlDelegateImpl mPageUrlDelegate;
18
19 private static final class PageUrlDelegateImpl
20 implements InstalledAppProviderImpl.PageUrlDelegate {
21 private final RenderFrameHost mRenderFrameHost;
22
23 public PageUrlDelegateImpl(RenderFrameHost renderFrameHost) {
24 mRenderFrameHost = renderFrameHost;
25 }
26
27 @Override
28 public URI getUrl() {
29 try {
30 return new URI(mRenderFrameHost.getLastCommittedURL());
dcheng 2017/03/21 07:37:50 Nit: seems like the RenderFrameHost interface shou
Matt Giuca 2017/03/21 07:46:01 Yes, I agree. I looked at doing this, but the only
boliu 2017/03/21 15:36:59 getLastCommittedURL can legitimately return null,
Matt Giuca 2017/03/22 00:28:47 Done. (If this returns null, it's handled in isAp
31 } catch (URISyntaxException e) {
32 throw new AssertionError(e);
33 }
34 }
35 }
36
37 public InstalledAppProviderFactory(RenderFrameHost renderFrameHost) {
38 mPageUrlDelegate = new PageUrlDelegateImpl(renderFrameHost);
39 }
40
41 @Override
42 public InstalledAppProvider createImpl() {
43 return new InstalledAppProviderImpl(mPageUrlDelegate, ContextUtils.getAp plicationContext());
44 }
45 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698