third_party/WebKit/public/platform/modules/installedapp/related_application.mojom - Issue 2706403014: Add Android implementation of navigator.getInstalledRelatedApps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/installedapp/related_application.mojom

Issue 2706403014: Add Android implementation of navigator.getInstalledRelatedApps. (Closed)

Patch Set: Fixed iframes (now has the correct origin of the frame, not the tab). Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/junit/src/org/chromium/content/browser/installedapp/InstalledAppProviderTest.java ('K') | « third_party/WebKit/public/platform/modules/installedapp/installed_app_provider.mojom ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 [JavaPackage="org.chromium.installedapp.mojom"]

5 module blink.mojom;	6 module blink.mojom;

6	7

7 // Represents a system application related to a particular web app.	8 // Represents a system application related to a particular web app.

8 // See: https://www.w3.org/TR/appmanifest/#dfn-application-object	9 // See: https://www.w3.org/TR/appmanifest/#dfn-application-object

9 struct RelatedApplication {	10 struct RelatedApplication {

10 string platform;	11 string platform;

11 // TODO(mgiuca): Change to url.mojom.Url (requires changing	12 // TODO(mgiuca): Change to url.mojom.Url (requires changing

12 // WebRelatedApplication as well).	13 // WebRelatedApplication as well).

13 string? url;	14 string? url;
	boliu 2017/03/17 18:02:56 I think this field is never used? I think this field is never used? Matt Giuca 2017/03/20 06:31:56 Hmm, it isn't used for checking, but it is passed Show quoted text On 2017/03/17 18:02:56, boliu wrote: > I think this field is never used? Hmm, it isn't used for checking, but it is passed into and back out of the Mojo interface. We need to return the same URL that was passed in, so it has to be in the Mojo interface. This reminds me: Added a test with a non-null URL to make sure the URL is preserved. (Hmm... perhaps a better Mojo interface for InstalledAppProvider would be to return a list of indices of the related applications, rather than the RelatedApplication objects themselves; that way the data does not need to roundtrip through Mojo and we can drop fields like \|url\| that are not used in the decision process, but need to be preserved. That refactor doesn't need to be done now, though.)
14 string? id;	15 string? id;

15 };	16 };

OLD	NEW