Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node.h

Issue 2706403008: [LayoutNG] Implement ComputeMinAndMaxContentSizes for inline (Closed)
Patch Set: Change the way to load ahem to make asan bot happy Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h
index 392ddc205e745ad79abd7bea837639ee94165e40..23908cbe23bfbb5ece0eeafb96ecfbd850029c0d 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h
@@ -22,6 +22,7 @@ class ComputedStyle;
class LayoutBlockFlow;
class LayoutObject;
class LayoutUnit;
+struct MinAndMaxContentSizes;
class NGConstraintSpace;
class NGLayoutInlineItem;
class NGLayoutInlineItemRange;
@@ -39,6 +40,7 @@ class CORE_EXPORT NGInlineNode : public NGLayoutInputNode {
RefPtr<NGLayoutResult> Layout(NGConstraintSpace*) override;
void LayoutInline(NGConstraintSpace*, NGLineBuilder*);
+ MinAndMaxContentSizes ComputeMinAndMaxContentSizes();
cbiesinger 2017/02/27 23:16:16 Please add a comment for this function, as well.
kojii 2017/02/28 03:30:37 Done.
NGInlineNode* NextSibling() override;
LayoutObject* GetLayoutObject() override;
@@ -46,6 +48,9 @@ class CORE_EXPORT NGInlineNode : public NGLayoutInputNode {
// calling the Layout method.
cbiesinger 2017/02/27 23:16:16 LayoutInline calls this function itself. Should it
kojii 2017/02/28 03:30:37 Done.
void PrepareLayout();
+ bool IsPrepareLayoutFinished() const { return !items_.isEmpty(); }
+ void InvalidatePrepareLayout();
+
const String& Text() const { return text_content_; }
String Text(unsigned start_offset, unsigned end_offset) const {
return text_content_.substring(start_offset, end_offset);

Powered by Google App Engine
This is Rietveld 408576698