Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2706383002: DO NOT SUBMIT: Show silent service manager failure (Closed)

Created:
3 years, 10 months ago by tibell
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT SUBMIT: Show silent service manager failure

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+823 lines, -11 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/preferences_manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download
M components/prefs/pref_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/prefs/pref_value_store.h View 3 chunks +12 lines, -1 line 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.h View 2 chunks +6 lines, -1 line 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.cc View 2 chunks +31 lines, -2 lines 0 comments Download
M content/child/service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.cc View 3 chunks +6 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
M services/preferences/public/cpp/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/pref_store_client.h View 1 chunk +68 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/pref_store_client.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/pref_store_impl.h View 1 chunk +63 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/pref_store_impl.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/pref_store_manager_impl.h View 1 chunk +79 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/pref_store_manager_impl.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/tests/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/tests/pref_store_client_unittest.cc View 1 chunk +176 lines, -0 lines 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 1 chunk +43 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/connector_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M services/service_manager/service_manager.cc View 9 chunks +25 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2692203007 Patch 140001

Powered by Google App Engine
This is Rietveld 408576698