chrome/browser/android/contextualsearch/contextual_search_manager.h - Issue 2706333002: [TTS] Add a Java Context linked to existing native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/contextualsearch/contextual_search_manager.h

Issue 2706333002: [TTS] Add a Java Context linked to existing native (Closed)

Patch Set: DCHECK that the context is created on the browser thread. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/contextualsearch/contextual_search_delegate.cc ('K') | « chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc ('k') | chrome/browser/android/contextualsearch/contextual_search_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/contextualsearch/contextual_search_manager.h

diff --git a/chrome/browser/android/contextualsearch/contextual_search_manager.h b/chrome/browser/android/contextualsearch/contextual_search_manager.h

index f1733761c6e50fb9c90155b35c7341182f853dad..1115509d0abe1461a99a463b0006aec9954ccba8 100644

--- a/chrome/browser/android/contextualsearch/contextual_search_manager.h

+++ b/chrome/browser/android/contextualsearch/contextual_search_manager.h

@@ -33,25 +33,20 @@ class ContextualSearchManager

// content view core object).

// Any outstanding server requests are canceled.

// When the server responds with the search term, the Java object is notified

- // by

- // calling OnSearchTermResolutionResponse().

+ // by calling OnSearchTermResolutionResponse().

void StartSearchTermResolutionRequest(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,

- const base::android::JavaParamRef<jstring>& j_selection,

- const base::android::JavaParamRef<jstring>& j_home_country,

- const base::android::JavaParamRef<jobject>& j_base_web_contents,

- jboolean j_may_send_base_page_url);

+ const base::android::JavaParamRef<jobject>& j_contextual_search_context,

+ const base::android::JavaParamRef<jobject>& j_base_web_contents);

// Gathers the surrounding text around the selection and saves it locally.

// Does not send a search term resolution request to the server.

void GatherSurroundingText(