[android] Generate strings.xml for android_webview.

[android] Generate strings.xml for android_webview.

This makes it possible for the android_webview component to generate
strings.xml files from .grd files in the android_webview_build
configuration.

BUG=internal b/11505352
TESTS=compile
TBR=jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269779

[mkosiba (inactive), 2014-05-08 18:46:45]

more resource fun :)

[newt (away), 2014-05-08 19:05:08]

one comment then lgtm

https://codereview.chromium.org/270633015/diff/1/content/content.gyp
File content/content.gyp (right):

https://codereview.chromium.org/270633015/diff/1/content/content.gyp#newcode438
content/content.gyp:438: 'java_strings_grd': 'android_content_strings.grd',
java_strings_grd isn't needed anymore

[cjhopman, 2014-05-08 19:06:41]

https://codereview.chromium.org/270633015/diff/1/build/java_strings_grd.gypi
File build/java_strings_grd.gypi (right):

https://codereview.chromium.org/270633015/diff/1/build/java_strings_grd.gypi#...
build/java_strings_grd.gypi:35: 'dependencies_res_input_dirs':
['<@(res_grit_dir)'],
I believe you also want:

  'dependencies_res_files': ['<(resource_input_paths)']

Dependencies add this list to the inputs to their resource processing (so adding
your inputs here will cause that step in dependencies to be run when one of your
inputs changes). Afaict, java_apk doesn't use this variable but it probably
should (I cannot tell if it gets this triggering from somewhere else or not).

I would just try to confirm that building then changing one of your inputs
properly triggers rebuilding of dependents.

[mkosiba (inactive), 2014-05-09 09:17:34]

https://codereview.chromium.org/270633015/diff/1/build/java_strings_grd.gypi
File build/java_strings_grd.gypi (right):

https://codereview.chromium.org/270633015/diff/1/build/java_strings_grd.gypi#...
build/java_strings_grd.gypi:35: 'dependencies_res_input_dirs':
['<@(res_grit_dir)'],
On 2014/05/08 19:06:42, cjhopman wrote:
> I believe you also want:
> 
>   'dependencies_res_files': ['<(resource_input_paths)']

Done.

> Dependencies add this list to the inputs to their resource processing (so
adding
> your inputs here will cause that step in dependencies to be run when one of
your
> inputs changes). Afaict, java_apk doesn't use this variable but it probably
> should (I cannot tell if it gets this triggering from somewhere else or not).
> 
> I would just try to confirm that building then changing one of your inputs
> properly triggers rebuilding of dependents.

I confirmed that touching the ui/android .grd file causes the process_resources,
javac, etc.. actions for ui_java to run.

[mkosiba (inactive), 2014-05-09 12:24:19]

https://codereview.chromium.org/270633015/diff/20001/build/java_strings_grd.gypi
File build/java_strings_grd.gypi (right):

https://codereview.chromium.org/270633015/diff/20001/build/java_strings_grd.g...
build/java_strings_grd.gypi:22:
'<(DEPTH)/build/android/setup.gyp:build_output_dirs'
not needed, the rule doesn't need any of the dirs from there and it messes with
the webview build.

[mkosiba (inactive), 2014-05-09 13:14:59]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-05-09 13:20:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkosiba@chromium.org/270633015/60001

[commit-bot: I haz the power, 2014-05-09 15:15:18]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[mkosiba (inactive), 2014-05-09 15:25:51]

+tbr jochen@ for content/chrome gyp changes.

[mkosiba (inactive), 2014-05-09 15:25:55]

The CQ bit was unchecked by mkosiba@chromium.org

[mkosiba (inactive), 2014-05-09 15:26:04]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-05-09 15:28:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkosiba@chromium.org/270633015/60001

[mkosiba (inactive), 2014-05-09 17:32:24]

The CQ bit was unchecked by mkosiba@chromium.org

[mkosiba (inactive), 2014-05-12 14:24:10]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-05-12 14:24:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkosiba@chromium.org/270633015/60001

[commit-bot: I haz the power, 2014-05-12 14:25:09]

Change committed as 269779