content/child/fileapi/webfilesystem_impl.cc - Issue 270633009: [FileAPI] Clean up WebFileSystemImpl before Blink shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/fileapi/webfilesystem_impl.cc

Issue 270633009: [FileAPI] Clean up WebFileSystemImpl before Blink shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +clean up on RenderThreadImpl Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/fileapi/webfilesystem_impl.cc

diff --git a/content/child/fileapi/webfilesystem_impl.cc b/content/child/fileapi/webfilesystem_impl.cc

index 62e9f0eda62f8f94b220f912c0a08585cebf20a7..9c4403a4170df850e2e6c8d8f657d9b6e9291e7d 100644

--- a/content/child/fileapi/webfilesystem_impl.cc

+++ b/content/child/fileapi/webfilesystem_impl.cc

@@ -342,8 +342,10 @@ WebFileSystemImpl* WebFileSystemImpl::ThreadSpecificInstance(

void WebFileSystemImpl::DeleteThreadSpecificInstance() {

DCHECK(!WorkerTaskRunner::Instance()->CurrentWorkerId());

- if (g_webfilesystem_tls.Pointer()->Get())

+ if (g_webfilesystem_tls.Pointer()->Get()) {

delete g_webfilesystem_tls.Pointer()->Get();

+ g_webfilesystem_tls.Pointer()->Set(NULL);

kinuko 2014/05/08 07:44:09 Don't we do this in WebFileSystemImpl dtor?

tzik 2014/05/08 08:05:30 Ah, yes, it's done in it. Reverted.

+ }

}

WebFileSystemImpl::WebFileSystemImpl(base::MessageLoopProxy* main_thread_loop)

« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | content/renderer/render_thread_impl.cc » ('J')