Move code from sync/api/attachments to sync/internal_api/attachments.

Move code from sync/api/attachments to sync/internal_api/attachments.

The goal is to reorganize the sync attachment code so that in the future
attachment code can include stuff it needs (like src/net/) without
loosening the DEPS rules for the rest of sync.

Replace internal_api's coarse grained dep on net/ with finer grained
deps.

sync/api/attachments - Home to attachment code that's needed by both
sync itself and users of sync.

sync/internal_api/public/attachments - Home to attachment headers needed
by sync/api/attachments.

sync/internal_api/attachments - Home to attachment code that's private
to sync.

TBR=mef,erikwright,phajdan.jr

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269481

[maniscalco, 2014-05-07 23:59:02]

Tim, would you please review this change?

Pavel, FYI.

[tim (not reviewing), 2014-05-08 17:39:28]

LGTM, but can you actually modify the internal_api DEPS file to also be more
specific and restricted to 

+net/base
+net/url_request
+net/test

To the extent possible I'd like to minimize the requirement on the stack. For
everything in sync that is not attachments, the dependency on net/ is trivial
(so wouldn't be a requirement for embedding).

[maniscalco, 2014-05-08 18:43:49]

On 2014/05/08 17:39:28, timsteele wrote:
> LGTM, but can you actually modify the internal_api DEPS file to also be more
> specific and restricted to 
> 
> +net/base
> +net/url_request
> +net/test
> 
> To the extent possible I'd like to minimize the requirement on the stack. For
> everything in sync that is not attachments, the dependency on net/ is trivial
> (so wouldn't be a requirement for embedding).

Sure... looks like http_bridge.cc needs a few more, net/cookies, net/dns,
net/http, and net/proxy.  I'll add those explicitly and drop the "+net".  Shout
if you disagree.

ERROR in
/usr/local/google/home/maniscalco/chromium/src/sync/internal_api/http_bridge.cc
  Illegal include: "net/cookies/cookie_monster.h"
    Because of no rule applying.
  Illegal include: "net/dns/host_resolver.h"
    Because of no rule applying.
  Illegal include: "net/http/http_cache.h"
    Because of no rule applying.
  Illegal include: "net/http/http_network_layer.h"
    Because of no rule applying.
  Illegal include: "net/http/http_response_headers.h"
    Because of no rule applying.
  Illegal include: "net/proxy/proxy_service.h"
    Because of no rule applying.


Thanks for the quick review!

[maniscalco, 2014-05-08 18:55:15]

On 2014/05/08 18:43:49, maniscalco wrote:
> On 2014/05/08 17:39:28, timsteele wrote:
> > LGTM, but can you actually modify the internal_api DEPS file to also be more
> > specific and restricted to 
> > 
> > +net/base
> > +net/url_request
> > +net/test
> > 
> > To the extent possible I'd like to minimize the requirement on the stack.
For
> > everything in sync that is not attachments, the dependency on net/ is
trivial
> > (so wouldn't be a requirement for embedding).
> 
> Sure... looks like http_bridge.cc needs a few more, net/cookies, net/dns,
> net/http, and net/proxy.  I'll add those explicitly and drop the "+net". 
Shout
> if you disagree.
> 
> ERROR in
>
/usr/local/google/home/maniscalco/chromium/src/sync/internal_api/http_bridge.cc
>   Illegal include: "net/cookies/cookie_monster.h"
>     Because of no rule applying.
>   Illegal include: "net/dns/host_resolver.h"
>     Because of no rule applying.
>   Illegal include: "net/http/http_cache.h"
>     Because of no rule applying.
>   Illegal include: "net/http/http_network_layer.h"
>     Because of no rule applying.
>   Illegal include: "net/http/http_response_headers.h"
>     Because of no rule applying.
>   Illegal include: "net/proxy/proxy_service.h"
>     Because of no rule applying.
> 
> 
> Thanks for the quick review!

Actually, it looks like I can drop the include of net/dns/host_resolver.h and
net/proxy/proxy_service.h and the remove those dirs from DEPS.

[maniscalco, 2014-05-08 18:55:42]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-05-08 19:01:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/270633005/160001

[commit-bot: I haz the power, 2014-05-08 23:40:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-08 23:52:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 23:52:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[maniscalco, 2014-05-09 00:11:42]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-05-09 00:16:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/270633005/160001

[commit-bot: I haz the power, 2014-05-09 00:28:38]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-09 00:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 00:35:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[maniscalco, 2014-05-09 16:55:11]

On 2014/05/09 00:35:56, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

Adding net/ subdir owners to TBR line since internal_api now depends on specific
net subdirs instead of just net/.

TBR reviewers, would you please take a look at sync/internal_api/DEPS: 

erikwright - for adding net/cookies
phajdan.jr - for net/test
mef - for net/base, net/http, and net/url_request

Thanks!

[maniscalco, 2014-05-09 16:55:21]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-05-09 16:59:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/270633005/160001

[commit-bot: I haz the power, 2014-05-10 02:02:08]

Change committed as 269481