Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 270633003: Remove RenderLayerCompositor::m_viewportConstrainedLayers (Closed)

Created:
6 years, 7 months ago by abarth-chromium
Modified:
6 years, 7 months ago
Reviewers:
Ian Vollick, chrishtr
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink, chrishtr, esprehn, ojan
Visibility:
Public.

Description

Remove RenderLayerCompositor::m_viewportConstrainedLayers This member variable and m_viewportConstrainedLayersNeedingUpdate aren't used by anything. R=vollick@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173559

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -59 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 2 chunks +1 line, -25 lines 3 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
6 years, 7 months ago (2014-05-07 20:01:19 UTC) #1
chrishtr
https://codereview.chromium.org/270633003/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp File Source/core/rendering/compositing/CompositingReasonFinder.cpp (right): https://codereview.chromium.org/270633003/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp#newcode244 Source/core/rendering/compositing/CompositingReasonFinder.cpp:244: return !layer->enclosingOverflowClipLayer(ExcludeSelf); I don't get why this is correct..
6 years, 7 months ago (2014-05-07 20:11:59 UTC) #2
abarth-chromium
https://codereview.chromium.org/270633003/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp File Source/core/rendering/compositing/CompositingReasonFinder.cpp (right): https://codereview.chromium.org/270633003/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp#newcode244 Source/core/rendering/compositing/CompositingReasonFinder.cpp:244: return !layer->enclosingOverflowClipLayer(ExcludeSelf); On 2014/05/07 20:12:00, chrishtr wrote: > I ...
6 years, 7 months ago (2014-05-07 20:18:54 UTC) #3
chrishtr
lgtm https://codereview.chromium.org/270633003/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp File Source/core/rendering/compositing/CompositingReasonFinder.cpp (right): https://codereview.chromium.org/270633003/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp#newcode244 Source/core/rendering/compositing/CompositingReasonFinder.cpp:244: return !layer->enclosingOverflowClipLayer(ExcludeSelf); On 2014/05/07 20:18:54, abarth wrote: > ...
6 years, 7 months ago (2014-05-07 20:20:42 UTC) #4
abarth-chromium
Thanks!
6 years, 7 months ago (2014-05-07 20:27:17 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 7 months ago (2014-05-07 20:27:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/270633003/1
6 years, 7 months ago (2014-05-07 20:27:54 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 21:14:50 UTC) #8
Message was sent while issue was closed. 
Change committed as 173559

Powered by Google App Engine
This is Rietveld 408576698