third_party/WebKit/public/platform/modules/media_capabilities/WebVideoConfiguration.h - Issue 2706313002: Media Capabilities: add plumbing between Blink and media/blink/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/media_capabilities/WebVideoConfiguration.h

Issue 2706313002: Media Capabilities: add plumbing between Blink and media/blink/. (Closed)

Patch Set: haraken comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/public/platform/modules/media_capabilities/WebMediaConfiguration.h ('K') | « third_party/WebKit/public/platform/modules/media_capabilities/WebMediaDecodingAbility.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebVideoConfiguration_h

	6 #define WebVideoConfiguration_h

	7

	8 #include "public/platform/WebString.h"

	9

	10 namespace blink {

	11

	12 // Represents a VideoConfiguration dictionary to be used outside of Blink.

	13 // It is created by Blink and passed to consumers that can assume that all

	14 // required fields are properly set.

	15 struct WebVideoConfiguration {

	16 WebString contentType;
	chcunningham 2017/03/08 02:43:10 I think the pattern for other media contentType pa I think the pattern for other media contentType passing is to split up the "audio/webm" from the "codecs='opus'" prior to pushing into the blink platform layer (and further). For e.g. HTMLMediaElement does this with canPlayType here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTML... Another view of this is from media/'s MimeUtil, where codecs and container are already separated. https://cs.chromium.org/chromium/src/media/base/mime_util.h?rcl=15e2840426713... mlamouri (slow - plz ping) 2017/03/10 11:26:42 I don't think it really matters where the check is Show quoted text On 2017/03/08 at 02:43:10, chcunningham wrote: > I think the pattern for other media contentType passing is to split up the "audio/webm" from the "codecs='opus'" prior to pushing into the blink platform layer (and further). For e.g. HTMLMediaElement does this with canPlayType here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTML... > > Another view of this is from media/'s MimeUtil, where codecs and container are already separated. > https://cs.chromium.org/chromium/src/media/base/mime_util.h?rcl=15e2840426713... I don't think it really matters where the check is made at the moment. I think it would make more sense for the MimeUtil to implement the codec splitting logic to avoid duplication. Though, we might need to reject if the `codec` parameter isn't present. I would say that changing the struct will have a low cost and we can revise this later. WDYT?
	17 unsigned width;

	18 unsigned height;

	19 unsigned bitrate;

	20 double framerate;

	21 };

	22

	23 } // namespace blink

	24

	25 #endif // WebVideoConfiguration_h

OLD	NEW