Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2706293014: Add preliminary support for method declarations to AstBuilder. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 9 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add preliminary support for method declarations to AstBuilder. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fb1bc6ad837d0a37d4449570672b0814ea4c7fe2

Patch Set 1 #

Patch Set 2 : Merge and fix test assertions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -148 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 7 chunks +3 lines, -129 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 1 2 chunks +43 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 9 months ago (2017-02-28 21:46:31 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-02-28 21:48:34 UTC) #3
Paul Berry
Committed patchset #2 (id:20001) manually as fb1bc6ad837d0a37d4449570672b0814ea4c7fe2 (presubmit successful).
3 years, 9 months ago (2017-02-28 23:05:36 UTC) #5
ahe
3 years, 9 months ago (2017-03-02 07:29:49 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698