third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js - Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog. (Closed)

Patch Set: test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

index 73d29087fa0349f87c8fa1f4097187f9ddb8d650..592de32a64e1774b10448e9529c00147bac73ef0 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

@@ -129,7 +129,7 @@ UI.SuggestBox = class {

if (this.visible())

return;

// TODO(dgozman): take document as a parameter.

- this._glassPane.showGlassPane(document);

+ this._glassPane.show(document);

this._rowHeight =

UI.measurePreferredSize(this.createElementForItem({text: '1', subtitle: '12'}), this._element).height;

}

@@ -138,7 +138,7 @@ UI.SuggestBox = class {

if (!this.visible())

return;

this._userInteracted = false;

- this._glassPane.hideGlassPane();

+ this._glassPane.hide();

}

/**