[DevTools] Fix Dialog's close button to properly close dialog.

third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Index: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
index e47c1e9ce08d8ade450665e73ee79e31b197f7a3..4da727968296e202853366eaa6ce49f5a5afeff5 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
@@ -77,7 +77,7 @@ UI.Dialog = class extends UI.GlassPane {
   addCloseButton() {
     var closeButton = this.contentElement.createChild('div', 'dialog-close-button', 'dt-close-button');
     closeButton.gray = true;
-    closeButton.addEventListener('click', () => this.detach(), false);
+    closeButton.addEventListener('click', () => this.hideDialog(), false);

[caseq, 2017/02/21 22:56:29]

So it looks like calling detach() on this one is a bad idea, right? Should we
move the logic of hideDialog into willHide() perhaps?

[dgozman, 2017/02/21 23:01:47]

I can try to do that in a follow up.

   }
 
   /**