[DevTools] Fix Dialog's close button to properly close dialog.

third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 107 matching lines @@
       }
 
       mainButtonClone.setToggled(action.toggled());
       buttons.push(mainButtonClone);
 
       var document = button.element.ownerDocument;
       document.documentElement.addEventListener('mouseup', mouseUp, false);
 
       var optionsGlassPane = new UI.GlassPane();
       optionsGlassPane.setBlockPointerEvents(true);
-      optionsGlassPane.showGlassPane(document);
+      optionsGlassPane.show(document);
       var optionsBar = new UI.Toolbar('fill', optionsGlassPane.contentElement);
       optionsBar._contentElement.classList.add('floating');
       const buttonHeight = 26;
 
-      var hostButtonPosition = button.element.totalOffset();
+      var hostButtonPosition = button.element.boxInWindow().relativeToElement(UI.GlassPane.container(document));
 
-      var topNotBottom = hostButtonPosition.top + buttonHeight * buttons.length < document.documentElement.offsetHeight;
+      var topNotBottom = hostButtonPosition.y + buttonHeight * buttons.length < document.documentElement.offsetHeight;
 
       if (topNotBottom)
         buttons = buttons.reverse();
 
       optionsBar.element.style.height = (buttonHeight * buttons.length) + 'px';
       if (topNotBottom)
-        optionsBar.element.style.top = (hostButtonPosition.top + 1) + 'px';
+        optionsBar.element.style.top = (hostButtonPosition.y - 5) + 'px';
       else
-        optionsBar.element.style.top = (hostButtonPosition.top - (buttonHeight * (buttons.length - 1))) + 'px';
-      optionsBar.element.style.left = (hostButtonPosition.left + 1) + 'px';
+        optionsBar.element.style.top = (hostButtonPosition.y - (buttonHeight * (buttons.length - 1)) - 6) + 'px';
+      optionsBar.element.style.left = (hostButtonPosition.x - 5) + 'px';
 
       for (var i = 0; i < buttons.length; ++i) {
         buttons[i].element.addEventListener('mousemove', mouseOver, false);
         buttons[i].element.addEventListener('mouseout', mouseOut, false);
         optionsBar.appendToolbarItem(buttons[i]);
       }
       var hostButtonIndex = topNotBottom ? 0 : buttons.length - 1;
       buttons[hostButtonIndex].element.classList.add('emulate-active');
 
       function mouseOver(e) {
         if (e.which !== 1)
           return;
         var buttonElement = e.target.enclosingNodeOrSelfWithClass('toolbar-item');
         buttonElement.classList.add('emulate-active');
       }
 
       function mouseOut(e) {
         if (e.which !== 1)
           return;
         var buttonElement = e.target.enclosingNodeOrSelfWithClass('toolbar-item');
         buttonElement.classList.remove('emulate-active');
       }
 
       function mouseUp(e) {
         if (e.which !== 1)
           return;
-        optionsGlassPane.hideGlassPane();
+        optionsGlassPane.hide();
         document.documentElement.removeEventListener('mouseup', mouseUp, false);
 
         for (var i = 0; i < buttons.length; ++i) {
           if (buttons[i].element.classList.contains('emulate-active')) {
             buttons[i].element.classList.remove('emulate-active');
             buttons[i]._clicked(e);
             break;
           }
         }
       }
@@ skipping 864 matching lines @@
   /**
    * @param {!Common.Setting} setting
    * @param {string=} tooltip
    * @param {string=} alternateTitle
    */
   constructor(setting, tooltip, alternateTitle) {
     super(alternateTitle || setting.title() || '', tooltip);
     UI.SettingsUI.bindCheckbox(this.inputElement, setting);
   }
 };