[DevTools] Fix Dialog's close button to properly close dialog.

third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 UI.Dialog = class extends UI.GlassPane {
   constructor() {
     super();
     this.registerRequiredCSS('ui/dialog.css');
     this.contentElement.tabIndex = 0;
-    this.contentElement.addEventListener('focus', this.focus.bind(this), false);
+    this.contentElement.addEventListener('focus', () => this.widget().focus(), false);
     this.contentElement.addEventListener('keydown', this._onKeyDown.bind(this), false);
     this.setBlockPointerEvents(true);
     this.setSetOutsideClickCallback(event => {
-      this.hideDialog();
+      this.hide();
       event.consume(true);
     });
     /** @type {!Map<!HTMLElement, number>} */
     this._tabIndexMap = new Map();
     /** @type {?UI.WidgetFocusRestorer} */
     this._focusRestorer = null;
   }
 
   /**
    * @return {boolean}
    */
   static hasInstance() {
     return !!UI.Dialog._instance;
   }
 
   /**
+   * @override
    * @param {!Document|!Element=} where
    */
-  showDialog(where) {
+  show(where) {
     var document = /** @type {!Document} */ (
         where instanceof Document ? where : (where || UI.inspectorView.element).ownerDocument);
     if (UI.Dialog._instance)
       UI.Dialog._instance.detach();
     UI.Dialog._instance = this;
     this._disableTabIndexOnElements(document);
-    this.showGlassPane(document);
-    this._focusRestorer = new UI.WidgetFocusRestorer(this);
+    super.show(document);
+    this._focusRestorer = new UI.WidgetFocusRestorer(this.widget());
   }
 
-  hideDialog() {
+  /**
+   * @override
+   */
+  hide() {
     this._focusRestorer.restore();
-    this.hideGlassPane();
+    super.hide();
     this._restoreTabIndexOnElements();
     delete UI.Dialog._instance;
   }
 
   addCloseButton() {
     var closeButton = this.contentElement.createChild('div', 'dialog-close-button', 'dt-close-button');
     closeButton.gray = true;
-    closeButton.addEventListener('click', () => this.detach(), false);
+    closeButton.addEventListener('click', () => this.hide(), false);
   }
 
   /**
    * @param {!Document} document
    */
   _disableTabIndexOnElements(document) {
     this._tabIndexMap.clear();
     for (var node = document; node; node = node.traverseNextNode(document)) {
       if (node instanceof HTMLElement) {
         var element = /** @type {!HTMLElement} */ (node);
@@ skipping 11 matching lines @@
       element.tabIndex = /** @type {number} */ (this._tabIndexMap.get(element));
     this._tabIndexMap.clear();
   }
 
   /**
    * @param {!Event} event
    */
   _onKeyDown(event) {
     if (event.keyCode === UI.KeyboardShortcut.Keys.Esc.code) {
       event.consume(true);
-      this.hideDialog();
+      this.hide();
     }
   }
 };