[DevTools] Fix Dialog's close button to properly close dialog.

third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 59 matching lines @@
   hideDialog() {
     this._focusRestorer.restore();
     this.hideGlassPane();
     this._restoreTabIndexOnElements();
     delete UI.Dialog._instance;
   }
 
   addCloseButton() {
     var closeButton = this.contentElement.createChild('div', 'dialog-close-button', 'dt-close-button');
     closeButton.gray = true;
-    closeButton.addEventListener('click', () => this.detach(), false);
+    closeButton.addEventListener('click', () => this.hideDialog(), false);

[caseq, 2017/02/21 22:56:29]

So it looks like calling detach() on this one is a bad idea, right? Should we
move the logic of hideDialog into willHide() perhaps?

[dgozman, 2017/02/21 23:01:47]

I can try to do that in a follow up.

   }
 
   /**
    * @param {!Document} document
    */
   _disableTabIndexOnElements(document) {
     this._tabIndexMap.clear();
     for (var node = document; node; node = node.traverseNextNode(document)) {
       if (node instanceof HTMLElement) {
         var element = /** @type {!HTMLElement} */ (node);
@@ skipping 15 matching lines @@
   /**
    * @param {!Event} event
    */
   _onKeyDown(event) {
     if (event.keyCode === UI.KeyboardShortcut.Keys.Esc.code) {
       event.consume(true);
       this.hideDialog();
     }
   }
 };