Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart

Issue 2706293004: Update TODO comments to refer to #28851. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
index 5e9603f95a2ab007f6baf4c911d04bb776198cd0..911e4307ad19369e170e51f8b6f8a6b15d27734e 100644
--- a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
+++ b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
@@ -654,7 +654,7 @@ class AstBuilder extends ScopeListener {
assert(modifiers == null);
analyzer.Token externalKeyword = null;
List<Annotation> metadata = pop();
- // TODO(paulberry): capture doc comments.
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
Comment comment = null;
push(ast.functionDeclaration(
comment,
@@ -704,7 +704,7 @@ class AstBuilder extends ScopeListener {
StringLiteral uri = pop();
List<Annotation> metadata = pop();
assert(metadata == null);
- // TODO(paulberry): capture doc comments.
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
Comment comment = null;
push(ast.importDirective(
comment,
@@ -727,7 +727,7 @@ class AstBuilder extends ScopeListener {
StringLiteral uri = pop();
List<Annotation> metadata = pop();
assert(metadata == null);
- // TODO(paulberry): capture doc comments.
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
Comment comment = null;
push(ast.exportDirective(comment, metadata, toAnalyzerToken(exportKeyword),
uri, configurations, combinators, toAnalyzerToken(semicolon)));
@@ -813,7 +813,8 @@ class AstBuilder extends ScopeListener {
assert(modifiers == null); // TODO(paulberry)
analyzer.Token abstractKeyword;
List<Annotation> metadata = pop();
- Comment comment = null; // TODO(paulberry)
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
+ Comment comment = null;
push(ast.classDeclaration(
comment,
metadata,
@@ -871,7 +872,8 @@ class AstBuilder extends ScopeListener {
assert(modifiers == null); // TODO(paulberry)
analyzer.Token abstractKeyword;
List<Annotation> metadata = pop();
- Comment comment = null; // TODO(paulberry)
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
+ Comment comment = null;
push(ast.classTypeAlias(
comment,
metadata,
@@ -898,7 +900,8 @@ class AstBuilder extends ScopeListener {
List<SimpleIdentifier> libraryName = pop();
var name = ast.libraryIdentifier(libraryName);
List<Annotation> metadata = pop();
- Comment comment = null; // TODO(paulberry)
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
+ Comment comment = null;
push(ast.libraryDirective(comment, metadata,
toAnalyzerToken(libraryKeyword), name, toAnalyzerToken(semicolon)));
accumulateIdentifierComponents = false;
@@ -922,7 +925,8 @@ class AstBuilder extends ScopeListener {
debugEvent("Part");
StringLiteral uri = pop();
List<Annotation> metadata = pop();
- Comment comment = null; // TODO(paulberry)
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
+ Comment comment = null;
push(ast.partDirective(comment, metadata, toAnalyzerToken(partKeyword), uri,
toAnalyzerToken(semicolon)));
}
@@ -943,7 +947,8 @@ class AstBuilder extends ScopeListener {
// in a reference to the "of" keyword.
var ofKeyword = partKeyword.next;
List<Annotation> metadata = pop();
- Comment comment = null; // TODO(paulberry)
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
+ Comment comment = null;
push(ast.partOfDirective(comment, metadata, toAnalyzerToken(partKeyword),
toAnalyzerToken(ofKeyword), uri, name, toAnalyzerToken(semicolon)));
accumulateIdentifierComponents = false;
@@ -991,7 +996,8 @@ class AstBuilder extends ScopeListener {
var modifiers = pop();
assert(modifiers == null); // TODO(paulberry)
List<Annotation> metadata = pop();
- Comment comment = null; // TODO(paulberry)
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
+ Comment comment = null;
push(ast.topLevelVariableDeclaration(
comment, metadata, variableList, toAnalyzerToken(endToken)));
}
@@ -1006,7 +1012,8 @@ class AstBuilder extends ScopeListener {
TypeAnnotation bound = pop();
SimpleIdentifier name = pop();
List<Annotation> metadata = null; // TODO(paulberry)
- Comment comment = null; // TODO(paulberry)
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
+ Comment comment = null;
push(ast.typeParameter(
comment, metadata, name, toAnalyzerToken(extendsOrSuper), bound));
}
@@ -1038,7 +1045,7 @@ class AstBuilder extends ScopeListener {
Token constKeyword = null; // TODO(paulberry)
Token factoryKeyword = null; // TODO(paulberry)
List<Annotation> metadata = pop();
- // TODO(paulberry): capture doc comments.
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
Comment comment = null;
SimpleIdentifier returnType2;
Token period;
@@ -1085,7 +1092,7 @@ class AstBuilder extends ScopeListener {
SimpleIdentifier name = pop();
TypeAnnotation returnType = pop();
List<Annotation> metadata = pop();
- // TODO(paulberry): capture doc comments.
+ // TODO(paulberry): capture doc comments. See dartbug.com/28851.
Comment comment = null;
push(ast.functionTypeAlias(
comment,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698