Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

Issue 2706243012: Fold svgAttributeChanged into parseAttribute for SVGAnimateElement (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
index 848d763e1746da23b269205cbe9cbb3604cc224c..9e1233aae880c4d28337adc9bf1ecc31dc79e12c 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
@@ -156,21 +156,15 @@ void SVGAnimateElement::parseAttribute(
const AttributeModificationParams& params) {
if (params.name == SVGNames::attributeTypeAttr) {
setAttributeType(params.newValue);
+ animationAttributeChanged();
return;
}
- SVGAnimationElement::parseAttribute(params);
-}
-
-void SVGAnimateElement::svgAttributeChanged(const QualifiedName& attrName) {
- if (attrName == SVGNames::attributeTypeAttr) {
- } else if (attrName == SVGNames::attributeNameAttr) {
- setAttributeName(constructQualifiedName(
- *this, fastGetAttribute(SVGNames::attributeNameAttr)));
- } else {
- SVGAnimationElement::svgAttributeChanged(attrName);
+ if (params.name == SVGNames::attributeNameAttr) {
+ setAttributeName(constructQualifiedName(*this, params.newValue));
+ animationAttributeChanged();
return;
}
- animationAttributeChanged();
+ SVGAnimationElement::parseAttribute(params);
}
void SVGAnimateElement::resolveTargetProperty() {
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698