Add LibraryIndex class for finding classes and members by name.

Add LibraryIndex class for finding classes and members by name.

The new class becomes a superclass of CoreTypes, which now gets its
functionality from that class, but also exposes commonly used built-in
members as fields.

This replaces a couple of ad-hoc linear searches spread throughout
the code.

The canonical names are not a convenient interface for transformers, so
the idea is that they can use LibraryIndex to address their own runtime
libraries.

To avoid name clashes and still have a somewhat convenient interface,
getters and setters are prefixed by 'get:' and 'set:' in the lookup
table (and only in the lookup table), and top-level members can be
accessed using '::' as the class name. This is the same convention
used by the VM, although it is currently not required to be the same.

R=dmitryas@google.com, karlklose@google.com, kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/a2e55c953d9ebce896f21ba7e08c05f60359d2fe

[asgerf, 2017-02-24 09:41:08]

asgerf@google.com changed reviewers:
+ dmitryas@google.com, karlklose@google.com, kmillikin@google.com

[Kevin Millikin (Google), 2017-02-24 10:21:08]

It is much nicer.  LGTM.

[karlklose, 2017-02-24 10:59:55]

LGTM

https://codereview.chromium.org/2706243011/diff/20001/pkg/kernel/lib/core_typ...
File pkg/kernel/lib/core_types.dart (right):

https://codereview.chromium.org/2706243011/diff/20001/pkg/kernel/lib/core_typ...
pkg/kernel/lib/core_types.dart:58: objectClass = getClass('dart:core',
'Object');
Maybe use the library to lookup:
  Library core = getLibrary('dart:core');
  objectClass = core.getClass('Object')'
  ...

[Dmitry Stefantsov, 2017-02-24 11:10:10]

LGTM

[asgerf, 2017-02-24 12:13:37]

https://codereview.chromium.org/2706243011/diff/20001/pkg/kernel/lib/core_typ...
File pkg/kernel/lib/core_types.dart (right):

https://codereview.chromium.org/2706243011/diff/20001/pkg/kernel/lib/core_typ...
pkg/kernel/lib/core_types.dart:58: objectClass = getClass('dart:core',
'Object');
On 2017/02/24 10:59:55, karlklose wrote:
> Maybe use the library to lookup:
>   Library core = getLibrary('dart:core');
>   objectClass = core.getClass('Object')'
>   ...

Library does not expose a getClass method. We could expose the _ClassTable
object to avoid repeatedly looking up dart:core, but since we cache the commonly
used classes in fields it probably doesn't matter.

[asgerf, 2017-02-24 13:49:19]

Description was changed from

==========
Add LibraryIndex class for finding classes and members by name.

The new class becomes a superclass of CoreTypes, which now gets its
functionality from that class, but also exposes commonly used built-in
members as fields.

This replaces a couple of ad-hoc linear searches spread throughout
the code.

The canonical names are not a convenient interface for transformers, so
the idea is that they can use LibraryIndex to address their own runtime
libraries.

To avoid name clashes and still have a somewhat convenient interface,
getters and setters are prefixed by 'get:' and 'set:' in the lookup
table (and only in the lookup table), and top-level members can be
accessed using '::' as the class name. This is the same convention
used by the VM, although it is currently not required to be the same.
==========

to

==========
Add LibraryIndex class for finding classes and members by name.

The new class becomes a superclass of CoreTypes, which now gets its
functionality from that class, but also exposes commonly used built-in
members as fields.

This replaces a couple of ad-hoc linear searches spread throughout
the code.

The canonical names are not a convenient interface for transformers, so
the idea is that they can use LibraryIndex to address their own runtime
libraries.

To avoid name clashes and still have a somewhat convenient interface,
getters and setters are prefixed by 'get:' and 'set:' in the lookup
table (and only in the lookup table), and top-level members can be
accessed using '::' as the class name. This is the same convention
used by the VM, although it is currently not required to be the same.

R=dmitryas@google.com, karlklose@google.com, kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a2e55c953d9ebce896f21ba7e08c05f60359d2fe
==========

[asgerf, 2017-02-24 13:49:20]

Committed patchset #5 (id:80001) manually as
a2e55c953d9ebce896f21ba7e08c05f60359d2fe (presubmit successful).