Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issue 270623007: Revert "HTML Imports: Fix yet another FOUC" (Closed)

Created:
6 years, 7 months ago by Hajime Morrita
Modified:
6 years, 7 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Revert "HTML Imports: Fix yet another FOUC" This reverts commit 7a3247bf431e08ab54c66fc5325855c129ed380a. Did conflict and resolved: LayoutTests/fast/html/imports/import-element-removed-flag.html LayoutTests/fast/html/imports/resources/import-helpers.js BUG=367386 TBR=esprehn@chromium.org

Patch Set 1 #

Patch Set 2 : Fixed bad merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M LayoutTests/fast/html/imports/import-element-removed-flag.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/html/imports/import-ignore-document-write.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/html/imports/import-link-with-media-query.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/fast/html/imports/resources/script-document-write.html View 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/http/tests/ManualTests/fouc/import-style-fouc.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/ManualTests/fouc/resources/slow-green.cgi View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Hajime Morrita
6 years, 7 months ago (2014-05-07 23:43:17 UTC) #1
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-07 23:43:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/270623007/1
6 years, 7 months ago (2014-05-07 23:44:17 UTC) #3
Hajime Morrita
The CQ bit was unchecked by morrita@chromium.org
6 years, 7 months ago (2014-05-07 23:53:20 UTC) #4
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-07 23:53:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/270623007/1
6 years, 7 months ago (2014-05-07 23:55:00 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 01:05:44 UTC) #7
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-08 01:13:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/270623007/2
6 years, 7 months ago (2014-05-08 01:14:12 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 02:28:02 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 03:46:41 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 04:59:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink
6 years, 7 months ago (2014-05-08 04:59:59 UTC) #13
esprehn
On 2014/05/08 04:59:59, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-08 05:10:33 UTC) #14
gmorrita
6 years, 7 months ago (2014-05-08 16:39:38 UTC) #15
Probably we should just land revised version.Let me see.

Powered by Google App Engine
This is Rietveld 408576698