chrome/browser/extensions/activity_log/uma_policy.cc - Issue 270623005: Update ActivityLog detection to use previous values, hrefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/uma_policy.cc

Issue 270623005: Update ActivityLog detection to use previous values, hrefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/ad_injection_browsertest.cc ('K') | « chrome/browser/extensions/activity_log/uma_policy.h ('k') | chrome/test/data/extensions/activity_log/ad_injection/content_script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/uma_policy.cc

diff --git a/chrome/browser/extensions/activity_log/uma_policy.cc b/chrome/browser/extensions/activity_log/uma_policy.cc

index e94f781eac05e5f87fd467b3f35efe9a93b252cb..ed395a8659863faef047ef13ab06960f7c68fadf 100644

--- a/chrome/browser/extensions/activity_log/uma_policy.cc

+++ b/chrome/browser/extensions/activity_log/uma_policy.cc

@@ -40,6 +40,7 @@ const int kCreatedObject = 1 << UmaPolicy::CREATED_OBJECT;

const int kAdInjected = 1 << UmaPolicy::AD_INJECTED;

const int kAdRemoved = 1 << UmaPolicy::AD_REMOVED;

const int kAdReplaced = 1 << UmaPolicy::AD_REPLACED;

+const int kAdLikelyReplaced = 1 << UmaPolicy::AD_LIKELY_REPLACED;

} // namespace

@@ -155,6 +156,9 @@ int UmaPolicy::MatchActionToStatus(scoped_refptr<Action> action) {

case Action::INJECTION_REPLACED_AD:

ret_bit |= kAdReplaced;

break;

+ case Action::INJECTION_LIKELY_REPLACED_AD:

+ ret_bit |= kAdLikelyReplaced;

+ break;

case Action::NO_AD_INJECTION:

break;

case Action::NUM_INJECTION_TYPES: