Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: chrome/browser/extensions/activity_log/uma_policy.cc

Issue 270623005: Update ActivityLog detection to use previous values, hrefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/uma_policy.cc
diff --git a/chrome/browser/extensions/activity_log/uma_policy.cc b/chrome/browser/extensions/activity_log/uma_policy.cc
index 63bcb7b132fe1262cee1331b66afd1485be51ac2..c9a5ac7d6987a89eab5414b793a9bce1cfa3e33a 100644
--- a/chrome/browser/extensions/activity_log/uma_policy.cc
+++ b/chrome/browser/extensions/activity_log/uma_policy.cc
@@ -41,6 +41,8 @@ const int kCreatedObject = 1 << UmaPolicy::CREATED_OBJECT;
const int kAdInjected = 1 << UmaPolicy::AD_INJECTED;
const int kAdRemoved = 1 << UmaPolicy::AD_REMOVED;
const int kAdReplaced = 1 << UmaPolicy::AD_REPLACED;
+const int kAdLikelyInjected = 1 << UmaPolicy::AD_LIKELY_INJECTED;
+const int kAdLikelyReplaced = 1 << UmaPolicy::AD_LIKELY_REPLACED;
// A mask of all the ad injection flags.
const int kAnyAdActivity = kAdInjected | kAdRemoved | kAdReplaced;
@@ -159,6 +161,12 @@ int UmaPolicy::MatchActionToStatus(scoped_refptr<Action> action) {
case Action::INJECTION_REPLACED_AD:
ret_bit |= kAdReplaced;
break;
+ case Action::INJECTION_LIKELY_NEW_AD:
+ ret_bit |= kAdLikelyInjected;
+ break;
+ case Action::INJECTION_LIKELY_REPLACED_AD:
+ ret_bit |= kAdLikelyReplaced;
+ break;
case Action::NO_AD_INJECTION:
break;
case Action::NUM_INJECTION_TYPES:
@@ -233,6 +241,10 @@ void UmaPolicy::HistogramOnClose(const std::string& cleaned_url,
statuses[AD_REMOVED - 1]);
UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(AD_REPLACED),
statuses[AD_REPLACED - 1]);
+ UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(AD_LIKELY_INJECTED),
+ statuses[AD_LIKELY_INJECTED - 1]);
+ UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(AD_LIKELY_REPLACED),
+ statuses[AD_LIKELY_REPLACED - 1]);
} else {
prefix += "Google.";
UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(CONTENT_SCRIPT),
@@ -267,6 +279,10 @@ void UmaPolicy::HistogramOnClose(const std::string& cleaned_url,
statuses[AD_REMOVED - 1]);
UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(AD_REPLACED),
statuses[AD_REPLACED - 1]);
+ UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(AD_LIKELY_INJECTED),
+ statuses[AD_LIKELY_INJECTED - 1]);
+ UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(AD_LIKELY_REPLACED),
+ statuses[AD_LIKELY_REPLACED - 1]);
}
}
@@ -412,6 +428,10 @@ const char* UmaPolicy::GetHistogramName(PageStatus status) {
return "AdRemoved";
case AD_REPLACED:
return "AdReplaced";
+ case AD_LIKELY_INJECTED:
+ return "AdLikelyInjected";
+ case AD_LIKELY_REPLACED:
+ return "AdLikelyReplaced";
case NONE:
case MAX_STATUS:
default:

Powered by Google App Engine
This is Rietveld 408576698