Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.h

Issue 270623005: Update ActivityLog detection to use previous values, hrefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log/activity_actions.h
diff --git a/chrome/browser/extensions/activity_log/activity_actions.h b/chrome/browser/extensions/activity_log/activity_actions.h
index 626d05091cd8715427574bc513050ac7e7c87d5e..9e82f367ab1b912e5e1df8097fd258257a599c35 100644
--- a/chrome/browser/extensions/activity_log/activity_actions.h
+++ b/chrome/browser/extensions/activity_log/activity_actions.h
@@ -47,11 +47,23 @@ class Action : public base::RefCountedThreadSafe<Action> {
// The type of ad injection an action performed.
enum InjectionType {
- NO_AD_INJECTION = 0, // No ad injection occurred.
- INJECTION_NEW_AD, // A new ad was injected.
- INJECTION_REMOVED_AD, // An ad was removed.
- INJECTION_REPLACED_AD, // An ad was replaced.
- NUM_INJECTION_TYPES // Place any new injection types above this entry.
+ // No ad injection occurred.
+ NO_AD_INJECTION = 0,
+ // A new ad was injected.
+ INJECTION_NEW_AD,
+ // An ad was removed.
+ INJECTION_REMOVED_AD,
+ // An ad was replaced.
+ INJECTION_REPLACED_AD,
+ // Something occurred which heuristically looks like an ad injection, but we
+ // didn't categorize it as such (likely because we didn't recognize it as
+ // an ad network). If our list is effective, this should be significantly
+ // lower than the non-LIKELY counterparts.
+ INJECTION_LIKELY_NEW_AD,
+ INJECTION_LIKELY_REPLACED_AD,
+
+ // Place any new injection types above this entry.
+ NUM_INJECTION_TYPES
};
// A useful shorthand for methods that take or return collections of Action
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698