Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 270623002: Remove chromium_builder_asan_mac target from all.gyp (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Remove chromium_builder_asan_mac target from all.gyp It was just an alias for chromium_builder_asan and it was removed from the buildbot scripts at https://codereview.chromium.org/257903004 ( svn://svn.chromium.org/chrome/trunk/tools/build@266374) BUG=None TEST=green trybots R=dpranke@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Is it safe to land this now?
6 years, 7 months ago (2014-05-07 05:09:42 UTC) #1
Dirk Pranke
lgtm
6 years, 7 months ago (2014-05-07 15:28:06 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-10 23:13:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270623002/1
6 years, 7 months ago (2014-05-10 23:13:42 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:35:23 UTC) #5
Message was sent while issue was closed.
Change committed as 269652

Powered by Google App Engine
This is Rietveld 408576698