Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1800)

Unified Diff: src/heap/heap.cc

Issue 2706213002: [heap] Unconditionally mark objects that undergo unsafe layout changes. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index b085a5d56ae3eaed8064fca3ac9b2dca97d395a2..b5e451b774a7e714014e8c87b21712f51a8bebec 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -4301,7 +4301,9 @@ void Heap::RegisterReservationsForBlackAllocation(Reservation* reservations) {
void Heap::NotifyObjectLayoutChange(HeapObject* object,
const DisallowHeapAllocation&) {
-// TODO(ulan): Add synchronization with the concurrent marker.
+ if (FLAG_incremental_marking && incremental_marking()->IsMarking()) {
+ incremental_marking()->MarkGrey(this, object);
+ }
#ifdef VERIFY_HEAP
DCHECK(pending_layout_change_object_ == nullptr);
pending_layout_change_object_ = object;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698