Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: ios/chrome/browser/web/navigation_manager_util_unittest.mm

Issue 2706173003: change navigation initiation type default value to RENDERER_INITIATED (Closed)
Patch Set: vv Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/web/navigation_manager_util.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/navigation_manager_util_unittest.mm
diff --git a/ios/chrome/browser/web/navigation_manager_util_unittest.mm b/ios/chrome/browser/web/navigation_manager_util_unittest.mm
index b02466b9cae9a5a7286f88e43861ac3d2f8a7472..1dc1b740439dba92020cc9bb06259ea2b2ff6f6d 100644
--- a/ios/chrome/browser/web/navigation_manager_util_unittest.mm
+++ b/ios/chrome/browser/web/navigation_manager_util_unittest.mm
@@ -4,81 +4,5 @@
#import "ios/chrome/browser/web/navigation_manager_util.h"
-#import "ios/web/public/navigation_item.h"
-#import "ios/web/public/test/fakes/test_navigation_manager.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#import "testing/gtest_mac.h"
-#include "testing/platform_test.h"
-#include "ui/base/page_transition_types.h"
-#include "url/gurl.h"
-
class NavigationManagerUtilTest : public PlatformTest {
- protected:
- web::TestNavigationManager nav_manager_;
};
-
-// Tests that empty navigation manager returns nullptr.
-TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemEmpty) {
- EXPECT_FALSE(GetLastNonRedirectedItem(nullptr));
- EXPECT_FALSE(GetLastNonRedirectedItem(&nav_manager_));
-}
-
-// Tests that typed in URL works correctly.
-TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemTypedUrl) {
- nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED);
- web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
- ASSERT_TRUE(item);
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED));
-}
-
-// Tests that link click works correctly.
-TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemLinkClicked) {
- nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_LINK);
- web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
- ASSERT_TRUE(item);
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- item->GetTransitionType(), ui::PAGE_TRANSITION_LINK));
-}
-
-// Tests that redirect items are skipped.
-TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemLinkMultiRedirects) {
- nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_LINK);
- nav_manager_.AddItem(GURL("http://bar.com/redir1"),
- ui::PAGE_TRANSITION_CLIENT_REDIRECT);
- nav_manager_.AddItem(GURL("http://bar.com/redir2"),
- ui::PAGE_TRANSITION_CLIENT_REDIRECT);
- web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
- ASSERT_TRUE(item);
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- item->GetTransitionType(), ui::PAGE_TRANSITION_LINK));
-}
-
-// Tests that when all items are redirects, the first one is returned.
-TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemAllRedirects) {
- nav_manager_.AddItem(GURL("http://bar.com/redir0"),
- ui::PAGE_TRANSITION_SERVER_REDIRECT);
- nav_manager_.AddItem(GURL("http://bar.com/redir1"),
- ui::PAGE_TRANSITION_CLIENT_REDIRECT);
- nav_manager_.AddItem(GURL("http://bar.com/redir2"),
- ui::PAGE_TRANSITION_CLIENT_REDIRECT);
- web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
- ASSERT_TRUE(item);
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- item->GetTransitionType(), ui::PAGE_TRANSITION_SERVER_REDIRECT));
-}
-
-// Tests that earlier redirects are not found.
-TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemNotEarliest) {
- nav_manager_.AddItem(GURL("http://foo.com/bookmark"),
- ui::PAGE_TRANSITION_AUTO_BOOKMARK);
- nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED);
- nav_manager_.AddItem(GURL("http://bar.com/redir1"),
- ui::PAGE_TRANSITION_CLIENT_REDIRECT);
- nav_manager_.AddItem(GURL("http://bar.com/redir2"),
- ui::PAGE_TRANSITION_CLIENT_REDIRECT);
- web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
- ASSERT_TRUE(item);
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED));
-}
« no previous file with comments | « ios/chrome/browser/web/navigation_manager_util.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698