change navigation initiation type default value to RENDERER_INITIATED

ios/web/navigation/navigation_item_impl.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/navigation/navigation_item_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 28 matching lines @@
 
 NavigationItemImpl::NavigationItemImpl()
     : unique_id_(GetUniqueIDInConstructor()),
       transition_type_(ui::PAGE_TRANSITION_LINK),
       is_overriding_user_agent_(false),
       is_created_from_push_state_(false),
       has_state_been_replaced_(false),
       is_created_from_hash_change_(false),
       should_skip_repost_form_confirmation_(false),
       navigation_initiation_type_(
-          web::NavigationInitiationType::USER_INITIATED),
+          web::NavigationInitiationType::RENDERER_INITIATED),
       is_unsafe_(false),
       facade_delegate_(nullptr) {}
 
 NavigationItemImpl::~NavigationItemImpl() {
 }
 
 NavigationItemImpl::NavigationItemImpl(const NavigationItemImpl& item)
     : unique_id_(item.unique_id_),
       original_request_url_(item.original_request_url_),
       url_(item.url_),
@@ skipping 241 matching lines @@
     http_request_headers_.reset();
 }
 
 void NavigationItemImpl::ResetHttpRequestHeaders() {
   http_request_headers_.reset();
 }
 
 void NavigationItemImpl::ResetForCommit() {
   // Any state that only matters when a navigation item is pending should be
   // cleared here.
-  SetNavigationInitiationType(web::NavigationInitiationType::USER_INITIATED);
+  SetNavigationInitiationType(
+      web::NavigationInitiationType::RENDERER_INITIATED);

[kkhorimoto, 2017/02/21 18:53:19]

This should remain as USER_INITIATED.  Once a RENDERER_INITIATED navigation is
committed, we show its URL in the omnibox.  Any back/forward navigations to that
NavigationItem should treat it as USER_INITIATED because the user has already
seen the URL and is (presumably) consciously navigating back to it, so it should
be used as the visible item.

[Eugene But (OOO till 7-30), 2017/02/21 19:03:40]

Is this actually true? During back forward navigation chrome should not show
pending URL in the omnibox:
https://docs.google.com/a/google.com/document/d/1GvsaoNtMO7d87FzoysOW5GqH6XEr...

[kkhorimoto, 2017/02/21 19:28:11]

That was at least the intention of this function when it was created.  Maybe
after your refactor this function isn't required anymore?  It definitely seems
wrong to set every NavigationItem to RENDERER_INITIATED upon committing.

[Eugene But (OOO till 7-30), 2017/02/21 19:33:29]

NavigationEntry also marks the entry as user-initiated:
void NavigationEntryImpl::ResetForCommit(FrameNavigationEntry* frame_entry) {
So seems like we want to keep current behavior (though I still not sure why :)).

Yuke, I think creis@ would be a good person to ask why ResetForCommit behaves
this way.

[liaoyuke, 2017/02/21 22:56:17]

Got it! Thank you for explaining!

 }
 
 }  // namespace web