Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3909)

Unified Diff: base/logging.h

Issue 2706143002: Fix win-clang build (Closed)
Patch Set: Use static_csat Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.h
diff --git a/base/logging.h b/base/logging.h
index 13661a764436c132813c0dc46032714804d5262b..b1075a456eebab479ef56c84efb406ef8527de94 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -510,9 +510,9 @@ class CheckOpResult {
// TODO(scottmg): Reinvestigate a short sequence that will work on both
// compilers once clang supports more intrinsics. See https://crbug.com/693713.
#if defined(__clang__)
-#define IMMEDIATE_CRASH() \
- (__debugbreak(), \
- (void)(*reinterpret_cast<volatile unsigned char*>(0) = __COUNTER__))
+#define IMMEDIATE_CRASH() \
+ (__debugbreak(), (void)(*reinterpret_cast<volatile unsigned char*>(0) = \
+ static_cast<unsigned char>(__COUNTER__)))
#else
#define IMMEDIATE_CRASH() __debugbreak()
#endif // __clang__
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698