Remove AnalysisErrorWithProperties and ErrorProperty.

Remove AnalysisErrorWithProperties and ErrorProperty.

It was not used in Analysis Server for some time, and we cannot use
it for any practical purpose with the new analysis driver.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/94556d578d108a31ed1000efa9a472d37660f2de

[Brian Wilkerson, 2017-02-20 22:16:43]

Are there any uses of any of this API outside the SDK? We might need to
deprecate it until they can be removed.

Other than that, lgtm.

[scheglov, 2017-02-20 23:13:34]

On 2017/02/20 22:16:43, Brian Wilkerson wrote:
> Are there any uses of any of this API outside the SDK? We might need to
> deprecate it until they can be removed.
> 
> Other than that, lgtm.

I don't see any uses internally outside of analyzer itself and (old versions) on
analysis server.
So, I think that it is safe to remove.

[scheglov, 2017-02-20 23:13:50]

Description was changed from

==========
Remove AnalysisErrorWithProperties and ErrorProperty.

It was not used in Analysis Server for some time, and we cannot use
it for any practical purpose with the new analysis driver.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Remove AnalysisErrorWithProperties and ErrorProperty.

It was not used in Analysis Server for some time, and we cannot use
it for any practical purpose with the new analysis driver.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/94556d578d108a31ed1000efa9a472d37660f2de
==========

[scheglov, 2017-02-20 23:13:51]

Committed patchset #1 (id:1) manually as
94556d578d108a31ed1000efa9a472d37660f2de (presubmit successful).