Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2706053002: Implement --fatal=errors. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M pkg/front_end/lib/src/fasta/compiler_command_line.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/errors.dart View 1 4 chunks +20 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/messages.dart View 1 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 10 months ago (2017-02-20 12:48:57 UTC) #2
karlklose
LGTM https://codereview.chromium.org/2706053002/diff/1/pkg/front_end/lib/src/fasta/errors.dart File pkg/front_end/lib/src/fasta/errors.dart (right): https://codereview.chromium.org/2706053002/diff/1/pkg/front_end/lib/src/fasta/errors.dart#newcode68 pkg/front_end/lib/src/fasta/errors.dart:68: if (areErrorsFatal) { I would prefer to call ...
3 years, 10 months ago (2017-02-20 12:53:10 UTC) #3
ahe
Thank you, Karl! https://codereview.chromium.org/2706053002/diff/1/pkg/front_end/lib/src/fasta/errors.dart File pkg/front_end/lib/src/fasta/errors.dart (right): https://codereview.chromium.org/2706053002/diff/1/pkg/front_end/lib/src/fasta/errors.dart#newcode68 pkg/front_end/lib/src/fasta/errors.dart:68: if (areErrorsFatal) { On 2017/02/20 12:53:10, ...
3 years, 10 months ago (2017-02-20 13:22:34 UTC) #4
ahe
3 years, 10 months ago (2017-02-20 13:23:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:2) manually as
a1b66ca1b79cc2f5b28d8e41887394994c5f7b50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698