Use WindowActivated message instead of VisibilityChanged message to determine that Ash is the activ…

win8/metro_driver/chrome_app_view_ash.cc

Index: win8/metro_driver/chrome_app_view_ash.cc
diff --git a/win8/metro_driver/chrome_app_view_ash.cc b/win8/metro_driver/chrome_app_view_ash.cc
index e39118b8501f7b6aa6c7ba22c24dea92e1a8bfa2..892e532dc75e45d160ab974e966170a4c32ab46c 100644
--- a/win8/metro_driver/chrome_app_view_ash.cc
+++ b/win8/metro_driver/chrome_app_view_ash.cc
@@ -884,8 +884,6 @@ HRESULT ChromeAppViewAsh::OnVisibilityChanged(
   HRESULT hr = args->get_Visible(&visible);
   if (FAILED(hr))
     return hr;
-
-  ui_channel_->Send(new MetroViewerHostMsg_VisibilityChanged(!!visible));

[cpu_(ooo_6.6-7.5), 2013/10/11 22:05:42]

Lets put some text on ChromeAppViewAsh::OnVisibilityChanged stating that we
migrated to OnWindowActivated and that we used to send
MetroViewerHostMsg_VisibilityChanged, but we ran into problems blah blah.

[gab, 2013/10/11 22:16:30]

Sure, I didn't feel a comment was needed as I think its fairly explicit to a
reader that now sees both both OnVisibilityChanged() and OnWindowActivated()
which one is used for what.

But if you feel this is needed, I'll add one. 

   return S_OK;
 }
 
@@ -896,6 +894,14 @@ HRESULT ChromeAppViewAsh::OnWindowActivated(
   HRESULT hr = args->get_WindowActivationState(&state);
   if (FAILED(hr))
     return hr;
+
+  // Treat both full activation (Ash was reopened from the Start Screen or from
+  // any other Metro entry point in Windows) and pointer activation (user
+  // clicked back in Ash after using another app on another monitor) the same.
+  if (state == winui::Core::CoreWindowActivationState_CodeActivated ||
+      state == winui::Core::CoreWindowActivationState_PointerActivated) {
+    ui_channel_->Send(new MetroViewerHostMsg_WindowActivated());
+  }

[cpu_(ooo_6.6-7.5), 2013/10/11 22:05:42]

so we don't need to know if we are deactivated? or non visible? I like not to
use GPU cycles if metro is not visible. It seems we want to pass a boolean to
the browser process.

[gab, 2013/10/11 22:16:30]

A deactivation message (i.e. state == CoreWindowActivationState_Deactivated) is
also sent when Ash remains visible on another monitor, yet it's not the active
window.

I think you'd want to implement that in OnVisibilityChanged() if anything; that
really tells you when Ash is no longer visible.

   return S_OK;
 }