Throw security errors for attribute access on detached windows.

Throw security errors for attribute access on detached windows.

BUG=693695

[dcheng, 2017-02-19 09:05:50]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org, jochen@chromium.org

[dcheng, 2017-02-19 09:05:51]

https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/security/detached-cross-frame-access.html
(right):

https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/security/detached-cross-frame-access.html:16:
test(function() {
This is a bit unsatisfactory, but otherwise, the test aborts at the first failed
assert.

[dcheng, 2017-02-19 09:05:53]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 09:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-19 09:14:10]

LGTM on my side.

https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp (right):

https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp:262:
LocalDOMWindow* callingWindow = currentDOMWindow(isolate);

Nit: callingWindow => currentWindow

(We removed the concept of CallingContext.)

[dcheng, 2017-02-19 09:19:46]

https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp (right):

https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp:262:
LocalDOMWindow* callingWindow = currentDOMWindow(isolate);
On 2017/02/19 09:14:10, haraken wrote:
> 
> Nit: callingWindow => currentWindow
> 
> (We removed the concept of CallingContext.)

Yeah, the reason I named it like this is for consistency with the
crossDomainAccessErrorMessage's and sanitizedCrossDomainAccessErrorMessage's
argument. Is it OK to fix this in a followup?

[haraken, 2017-02-19 09:41:19]

On 2017/02/19 09:19:46, dcheng wrote:
>
https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp (right):
> 
>
https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp:262:
> LocalDOMWindow* callingWindow = currentDOMWindow(isolate);
> On 2017/02/19 09:14:10, haraken wrote:
> > 
> > Nit: callingWindow => currentWindow
> > 
> > (We removed the concept of CallingContext.)
> 
> Yeah, the reason I named it like this is for consistency with the
> crossDomainAccessErrorMessage's and sanitizedCrossDomainAccessErrorMessage's
> argument. Is it OK to fix this in a followup?

sure.

[dcheng, 2017-02-19 09:52:20]

On 2017/02/19 09:19:46, dcheng wrote:
>
https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp (right):
> 
>
https://codereview.chromium.org/2705783004/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp:262:
> LocalDOMWindow* callingWindow = currentDOMWindow(isolate);
> On 2017/02/19 09:14:10, haraken wrote:
> > 
> > Nit: callingWindow => currentWindow
> > 
> > (We removed the concept of CallingContext.)
> 
> Yeah, the reason I named it like this is for consistency with the
> crossDomainAccessErrorMessage's and sanitizedCrossDomainAccessErrorMessage's
> argument. Is it OK to fix this in a followup?

OK, I guess this patch is not going to be so simple after all, it changes quite
a few results.

[dcheng, 2017-02-20 03:32:13]

Description was changed from

==========
Throw security errors for attribute access on detached windows.

BUG=693695
==========

to

==========
Throw security errors for attribute access on detached windows.

BUG=693695
==========