[Autofill] Move country combo box model from chrome to component.

chrome/browser/ui/autofill/country_combobox_model_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/ui/autofill/country_combobox_model.h"
+#include "components/autofill/core/browser/country_combobox_model.h"
 
 #include <memory>
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/autofill/core/browser/autofill_country.h"
 #include "components/autofill/core/browser/test_personal_data_manager.h"
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui_component.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/localization.h"
 
 namespace autofill {
 
 class CountryComboboxModelTest : public testing::Test {
  public:
   CountryComboboxModelTest() {
     manager_.Init(

[Mathieu, 2017/02/21 00:57:19]

Do we need lines 28-31? If not, that means we can get rid of all the chrome/
dependencies and move this test next to the feature code.

[MAD, 2017/02/21 15:56:18]

It could be replaced with a mock.

         NULL, profile_.GetPrefs(),
         AccountTrackerServiceFactory::GetForProfile(&profile_),
         SigninManagerFactory::GetForProfile(&profile_), false);
     manager_.set_timezone_country_code("KR");
     model_.reset(new CountryComboboxModel());
-    model_->SetCountries(manager_, base::Callback<bool(const std::string&)>());
+    model_->SetCountries(manager_, base::Callback<bool(const std::string&)>(),
+                         g_browser_process->GetApplicationLocale());

[Mathieu, 2017/02/21 00:57:19]

It seems like we are testing "KR" - Korea, above. So we can pass "ko-KR" here I
guess...

[MAD, 2017/02/21 15:56:18]

It's a bit weird that it works with the browser process app locale here and a
hard coded country above... I could dig a bit deeper to understand better.

   }
 
   TestPersonalDataManager* manager() { return &manager_; }
   CountryComboboxModel* model() { return model_.get(); }
 
  private:
   // NB: order is important here - |profile_| must go down after |manager_|.
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
   TestPersonalDataManager manager_;
@@ skipping 18 matching lines @@
 
     std::string country_code = model()->countries()[i]->country_code();
     std::vector< ::i18n::addressinput::AddressUiComponent> components =
         ::i18n::addressinput::BuildComponents(
             country_code, localization, std::string(), &unused);
     EXPECT_FALSE(components.empty()) << " for country " << country_code;
   }
 }
 
 }  // namespace autofill