[Extensions] Deprecate old install prompt types

chrome/browser/extensions/extension_install_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_prompt.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/location.h"
@@ skipping 42 matching lines @@
 using extensions::PermissionSet;
 
 namespace {
 
 bool AllowWebstoreData(ExtensionInstallPrompt::PromptType type) {
   return type == ExtensionInstallPrompt::INLINE_INSTALL_PROMPT ||
          type == ExtensionInstallPrompt::EXTERNAL_INSTALL_PROMPT ||
          type == ExtensionInstallPrompt::REPAIR_PROMPT;
 }
 
-static const int kTitleIds[ExtensionInstallPrompt::NUM_PROMPT_TYPES] = {
-    IDS_EXTENSION_INSTALL_PROMPT_TITLE,
-    IDS_EXTENSION_INSTALL_PROMPT_TITLE,
-    0,  // Deprecated.
-    IDS_EXTENSION_RE_ENABLE_PROMPT_TITLE,
-    IDS_EXTENSION_PERMISSIONS_PROMPT_TITLE,
-    0,  // External installs use different strings for extensions/apps/themes.
-    IDS_EXTENSION_POST_INSTALL_PERMISSIONS_PROMPT_TITLE,
-    IDS_EXTENSION_LAUNCH_APP_PROMPT_TITLE,
-    IDS_EXTENSION_REMOTE_INSTALL_PROMPT_TITLE,
-    IDS_EXTENSION_REPAIR_PROMPT_TITLE,
-    IDS_EXTENSION_DELEGATED_INSTALL_PROMPT_TITLE,
-    0,  // Deprecated.
-};
-static const int kButtons[ExtensionInstallPrompt::NUM_PROMPT_TYPES] = {
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    // The "OK" button in the post install permissions dialog allows revoking
-    // file/device access, and is only shown if such permissions exist; see
-    // ShouldDisplayRevokeButton().
-    ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-    ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL,
-};
-static const int kAcceptButtonIds[ExtensionInstallPrompt::NUM_PROMPT_TYPES] = {
-    0,  // Regular installs use different strings for extensions/apps/themes.
-    0,  // Inline installs as well.
-    IDS_EXTENSION_PROMPT_INSTALL_BUTTON,
-    IDS_EXTENSION_PROMPT_RE_ENABLE_BUTTON,
-    IDS_EXTENSION_PROMPT_PERMISSIONS_BUTTON,
-    0,  // External installs use different strings for extensions/apps/themes.
-    0,  // Different strings depending on the files and devices retained.
-    IDS_EXTENSION_PROMPT_LAUNCH_BUTTON,
-    0,  // Remote installs use different strings for extensions/apps.
-    0,  // Repairs use different strings for extensions/apps.
-    IDS_EXTENSION_PROMPT_INSTALL_BUTTON,
-    IDS_EXTENSION_PROMPT_INSTALL_BUTTON,
-};
-static const int kAbortButtonIds[ExtensionInstallPrompt::NUM_PROMPT_TYPES] = {
-    IDS_CANCEL,
-    IDS_CANCEL,
-    IDS_CANCEL,
-    IDS_CANCEL,
-    IDS_EXTENSION_PROMPT_PERMISSIONS_ABORT_BUTTON,
-    IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ABORT_BUTTON,
-    IDS_CLOSE,
-    IDS_CANCEL,
-    IDS_CANCEL,
-    IDS_CANCEL,
-    IDS_CANCEL,
-    IDS_CANCEL,
-};
-static const int
-    kPermissionsHeaderIds[ExtensionInstallPrompt::NUM_PROMPT_TYPES] = {
-        IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_THESE_WILL_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_WILL_NOW_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_WANTS_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_CAN_ACCESS,
-        IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_CAN_ACCESS,
-        IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO,
-        IDS_EXTENSION_PROMPT_THESE_WILL_HAVE_ACCESS_TO,
-};
-
 // Returns bitmap for the default icon with size equal to the default icon's
 // pixel size under maximal supported scale factor.
 SkBitmap GetDefaultIconBitmapForMaxScaleFactor(bool is_app) {
   const gfx::ImageSkia& image = is_app ?
       extensions::util::GetDefaultAppIcon() :
       extensions::util::GetDefaultExtensionIcon();
   return image.GetRepresentation(
       gfx::ImageSkia::GetMaxSupportedScale()).sk_bitmap();
 }
 
@@ skipping 55 matching lines @@
     case ExtensionInstallPrompt::EXTERNAL_INSTALL_PROMPT:
       return "EXTERNAL_INSTALL_PROMPT";
     case ExtensionInstallPrompt::POST_INSTALL_PERMISSIONS_PROMPT:
       return "POST_INSTALL_PERMISSIONS_PROMPT";
     case ExtensionInstallPrompt::REMOTE_INSTALL_PROMPT:
       return "REMOTE_INSTALL_PROMPT";
     case ExtensionInstallPrompt::REPAIR_PROMPT:
       return "REPAIR_PROMPT";
     case ExtensionInstallPrompt::DELEGATED_PERMISSIONS_PROMPT:
       return "DELEGATED_PERMISSIONS_PROMPT";
-    case ExtensionInstallPrompt::LAUNCH_PROMPT_DEPRECATED:
-    case ExtensionInstallPrompt::BUNDLE_INSTALL_PROMPT_DEPRECATED:
-    case ExtensionInstallPrompt::DELEGATED_BUNDLE_PERMISSIONS_PROMPT_DEPRECATED:
-      NOTREACHED();
-      // fall through:
     case ExtensionInstallPrompt::UNSET_PROMPT_TYPE:
     case ExtensionInstallPrompt::NUM_PROMPT_TYPES:
+      NOTREACHED();

[lazyboy, 2017/02/21 21:43:05]

Can types_ be ever set to these upon constructing ExtensionInstallPrompt?
If not, maybe we can DCHECK these in the constructor and make type_ const. I
couldn't find code that calls ExtensionInstallPrompt::set_type()...

[Devlin, 2017/02/22 00:08:40]

Done.

       break;
   }
   return "OTHER";
 }
 
 ExtensionInstallPrompt::Prompt::Prompt(PromptType type)
     : type_(type),
       is_showing_details_for_retained_files_(false),
       is_showing_details_for_retained_devices_(false),
       extension_(NULL),
@@ skipping 63 matching lines @@
     int rating_count) {
   CHECK(AllowWebstoreData(type_));
   localized_user_count_ = localized_user_count;
   show_user_count_ = show_user_count;
   average_rating_ = average_rating;
   rating_count_ = rating_count;
   has_webstore_data_ = true;
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetDialogTitle() const {
-  int id = kTitleIds[type_];
-  if (type_ == DELEGATED_PERMISSIONS_PROMPT) {
-    return l10n_util::GetStringFUTF16(id, base::UTF8ToUTF16(extension_->name()),
-                                      base::UTF8ToUTF16(delegated_username_));
+  int id = -1;
+  switch (type_) {
+    case INSTALL_PROMPT:
+    case INLINE_INSTALL_PROMPT:
+      id = IDS_EXTENSION_INSTALL_PROMPT_TITLE;
+      break;
+    case RE_ENABLE_PROMPT:
+      id = IDS_EXTENSION_RE_ENABLE_PROMPT_TITLE;
+      break;
+    case PERMISSIONS_PROMPT:
+      id = IDS_EXTENSION_PERMISSIONS_PROMPT_TITLE;
+      break;
+    case EXTERNAL_INSTALL_PROMPT:
+      if (extension_->is_app())
+        id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_TITLE_APP;
+      else if (extension_->is_theme())
+        id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_TITLE_THEME;
+      else
+        id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_TITLE_EXTENSION;
+      break;
+    case POST_INSTALL_PERMISSIONS_PROMPT:
+      id = IDS_EXTENSION_POST_INSTALL_PERMISSIONS_PROMPT_TITLE;
+      break;
+    case REMOTE_INSTALL_PROMPT:
+      id = IDS_EXTENSION_REMOTE_INSTALL_PROMPT_TITLE;
+      break;
+    case REPAIR_PROMPT:
+      id = IDS_EXTENSION_REPAIR_PROMPT_TITLE;
+      break;
+    case DELEGATED_PERMISSIONS_PROMPT:
+      // Special case: need to include the delegated username.
+      return l10n_util::GetStringFUTF16(
+          IDS_EXTENSION_DELEGATED_INSTALL_PROMPT_TITLE,
+          base::UTF8ToUTF16(extension_->name()),
+          base::UTF8ToUTF16(delegated_username_));
+    case UNSET_PROMPT_TYPE:
+    case NUM_PROMPT_TYPES:
+      NOTREACHED();
   }
-  if (type_ == EXTERNAL_INSTALL_PROMPT) {
-    if (extension_->is_app())
-      id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_TITLE_APP;
-    else if (extension_->is_theme())
-      id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_TITLE_THEME;
-    else
-      id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_TITLE_EXTENSION;
-  }
+
   return l10n_util::GetStringFUTF16(id, base::UTF8ToUTF16(extension_->name()));
 }
 
 int ExtensionInstallPrompt::Prompt::GetDialogButtons() const {
-  if (type_ == POST_INSTALL_PERMISSIONS_PROMPT && ShouldDisplayRevokeButton()) {
-    return kButtons[type_] | ui::DIALOG_BUTTON_OK;
+  int buttons = 0;
+  switch (type_) {
+    case INSTALL_PROMPT:
+    case INLINE_INSTALL_PROMPT:
+    case RE_ENABLE_PROMPT:
+    case PERMISSIONS_PROMPT:
+    case EXTERNAL_INSTALL_PROMPT:
+    case REMOTE_INSTALL_PROMPT:
+    case REPAIR_PROMPT:
+    case DELEGATED_PERMISSIONS_PROMPT:
+      buttons = ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL;
+      break;
+    case POST_INSTALL_PERMISSIONS_PROMPT:
+      buttons = ui::DIALOG_BUTTON_CANCEL;

[lazyboy, 2017/02/21 21:43:05]

Since there's only one special case, I think even the following would be simpler
to read:

DCHECK(type_ != UNSET_PROMPT_TYPE && type_ != NUM_PROMPT_TYPES)
if (type_ == POST_INSTALL_PERMISSIONS_PROMPT)
  if (ShouldDisplayRevokeButton()) return CANCEL|OK;
  else return CANCEL;

return OK|CANCEL;

[Devlin, 2017/02/22 00:08:40]

Done.

+      // The "OK" button in the post install permissions dialog allows revoking
+      // file/device access, and is only shown if such permissions exist; see
+      // ShouldDisplayRevokeButton().
+      if (ShouldDisplayRevokeButton())
+        buttons |= ui::DIALOG_BUTTON_OK;
+      break;
+    case UNSET_PROMPT_TYPE:
+    case NUM_PROMPT_TYPES:
+      NOTREACHED();
   }
-
-  return kButtons[type_];
+  return buttons;
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetAcceptButtonLabel() const {
-  int id = kAcceptButtonIds[type_];
+  int id = -1;
+  switch (type_) {
+    case INSTALL_PROMPT:
+    case INLINE_INSTALL_PROMPT:
+      if (extension_->is_app())
+        id = IDS_EXTENSION_INSTALL_PROMPT_ACCEPT_BUTTON_APP;
+      else if (extension_->is_theme())
+        id = IDS_EXTENSION_INSTALL_PROMPT_ACCEPT_BUTTON_THEME;
+      else
+        id = IDS_EXTENSION_INSTALL_PROMPT_ACCEPT_BUTTON_EXTENSION;
+      break;
+    case RE_ENABLE_PROMPT:

[lazyboy, 2017/02/21 21:43:05]

RE_ENABLE_PROMPT used to return
IDS_EXTENSION_PROMPT_RE_ENABLE_BUTTON (kAccpetButtonIds[3])

PERMISSIONS_PROMPT used to return
IDS_EXTENSION_PROMPT_PERMISSIONS_BUTTON (kAcceptButtonIds[4])

Is this change intentional?

[Devlin, 2017/02/22 00:08:40]

Good catch!  Changed.

+    case PERMISSIONS_PROMPT:
+    case EXTERNAL_INSTALL_PROMPT:
+      if (extension_->is_app())
+        id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ACCEPT_BUTTON_APP;
+      else if (extension_->is_theme())
+        id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ACCEPT_BUTTON_THEME;
+      else
+        id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ACCEPT_BUTTON_EXTENSION;
+      break;
+    case POST_INSTALL_PERMISSIONS_PROMPT:
+      if (GetRetainedFileCount() && GetRetainedDeviceCount()) {
+        id =
+            IDS_EXTENSION_PROMPT_PERMISSIONS_CLEAR_RETAINED_FILES_AND_DEVICES_BUTTON;
+      } else if (GetRetainedFileCount()) {
+        id = IDS_EXTENSION_PROMPT_PERMISSIONS_CLEAR_RETAINED_FILES_BUTTON;
+      } else if (GetRetainedDeviceCount()) {
+        id = IDS_EXTENSION_PROMPT_PERMISSIONS_CLEAR_RETAINED_DEVICES_BUTTON;
+      }
+      // If there are neither retained files nor devices, leave id 0 so there

[lazyboy, 2017/02/21 21:43:05]

"leave id to -1"

[Devlin, 2017/02/22 00:08:40]

Done.

+      // will be no "accept" button.
+      break;
+    case REMOTE_INSTALL_PROMPT:
+      if (extension_->is_app())
+        id = IDS_EXTENSION_PROMPT_REMOTE_INSTALL_BUTTON_APP;
+      else
+        id = IDS_EXTENSION_PROMPT_REMOTE_INSTALL_BUTTON_EXTENSION;
+      break;
+    case REPAIR_PROMPT:
+      if (extension_->is_app())
+        id = IDS_EXTENSION_PROMPT_REPAIR_BUTTON_APP;
+      else
+        id = IDS_EXTENSION_PROMPT_REPAIR_BUTTON_EXTENSION;
+      break;
+    case DELEGATED_PERMISSIONS_PROMPT:
+      id = IDS_EXTENSION_PROMPT_INSTALL_BUTTON;
+      break;
+    case UNSET_PROMPT_TYPE:
+    case NUM_PROMPT_TYPES:
+      NOTREACHED();
+  }
 
-  if (type_ == INSTALL_PROMPT || type_ == INLINE_INSTALL_PROMPT) {
-    if (extension_->is_app())
-      id = IDS_EXTENSION_INSTALL_PROMPT_ACCEPT_BUTTON_APP;
-    else if (extension_->is_theme())
-      id = IDS_EXTENSION_INSTALL_PROMPT_ACCEPT_BUTTON_THEME;
-    else
-      id = IDS_EXTENSION_INSTALL_PROMPT_ACCEPT_BUTTON_EXTENSION;
-  } else if (type_ == EXTERNAL_INSTALL_PROMPT) {
-    if (extension_->is_app())
-      id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ACCEPT_BUTTON_APP;
-    else if (extension_->is_theme())
-      id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ACCEPT_BUTTON_THEME;
-    else
-      id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ACCEPT_BUTTON_EXTENSION;
-  } else if (type_ == POST_INSTALL_PERMISSIONS_PROMPT) {
-    if (GetRetainedFileCount() && GetRetainedDeviceCount()) {
-      id =
-          IDS_EXTENSION_PROMPT_PERMISSIONS_CLEAR_RETAINED_FILES_AND_DEVICES_BUTTON;
-    } else if (GetRetainedFileCount()) {
-      id = IDS_EXTENSION_PROMPT_PERMISSIONS_CLEAR_RETAINED_FILES_BUTTON;
-    } else if (GetRetainedDeviceCount()) {
-      id = IDS_EXTENSION_PROMPT_PERMISSIONS_CLEAR_RETAINED_DEVICES_BUTTON;
-    }
-    // If there are neither retained files nor devices, leave id 0 so there
-    // will be no "accept" button.
-  } else if (type_ == REMOTE_INSTALL_PROMPT) {
-    if (extension_->is_app())
-      id = IDS_EXTENSION_PROMPT_REMOTE_INSTALL_BUTTON_APP;
-    else
-      id = IDS_EXTENSION_PROMPT_REMOTE_INSTALL_BUTTON_EXTENSION;
-  } else if (type_ == REPAIR_PROMPT) {
-    if (extension_->is_app())
-      id = IDS_EXTENSION_PROMPT_REPAIR_BUTTON_APP;
-    else
-      id = IDS_EXTENSION_PROMPT_REPAIR_BUTTON_EXTENSION;
-  }
-  return id ? l10n_util::GetStringUTF16(id) : base::string16();
+  return id != -1 ? l10n_util::GetStringUTF16(id) : base::string16();
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetAbortButtonLabel() const {
-  return l10n_util::GetStringUTF16(kAbortButtonIds[type_]);
+  int id = -1;
+  switch (type_) {
+    case INSTALL_PROMPT:
+    case INLINE_INSTALL_PROMPT:
+    case RE_ENABLE_PROMPT:
+    case REMOTE_INSTALL_PROMPT:
+    case REPAIR_PROMPT:
+    case DELEGATED_PERMISSIONS_PROMPT:
+      id = IDS_CANCEL;
+      break;
+    case PERMISSIONS_PROMPT:
+      id = IDS_EXTENSION_PROMPT_PERMISSIONS_ABORT_BUTTON;
+      break;
+    case EXTERNAL_INSTALL_PROMPT:
+      id = IDS_EXTENSION_EXTERNAL_INSTALL_PROMPT_ABORT_BUTTON;
+      break;
+    case POST_INSTALL_PERMISSIONS_PROMPT:
+      id = IDS_CLOSE;
+      break;
+    case UNSET_PROMPT_TYPE:
+    case NUM_PROMPT_TYPES:
+      NOTREACHED();
+  }
+
+  return l10n_util::GetStringUTF16(id);
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetPermissionsHeading(
     PermissionsType permissions_type) const {
   switch (permissions_type) {
-    case REGULAR_PERMISSIONS:
-      return l10n_util::GetStringUTF16(kPermissionsHeaderIds[type_]);
+    case REGULAR_PERMISSIONS: {
+      int id = -1;
+      switch (type_) {
+        case INSTALL_PROMPT:
+        case INLINE_INSTALL_PROMPT:
+        case EXTERNAL_INSTALL_PROMPT:
+        case REMOTE_INSTALL_PROMPT:
+        case DELEGATED_PERMISSIONS_PROMPT:
+          id = IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO;
+          break;
+        case RE_ENABLE_PROMPT:
+          id = IDS_EXTENSION_PROMPT_WILL_NOW_HAVE_ACCESS_TO;
+          break;
+        case PERMISSIONS_PROMPT:
+          id = IDS_EXTENSION_PROMPT_WANTS_ACCESS_TO;
+          break;
+        case POST_INSTALL_PERMISSIONS_PROMPT:
+        case REPAIR_PROMPT:
+          id = IDS_EXTENSION_PROMPT_CAN_ACCESS;
+          break;
+        case UNSET_PROMPT_TYPE:
+        case NUM_PROMPT_TYPES:
+          NOTREACHED();
+      }
+      return l10n_util::GetStringUTF16(id);
+    }
     case WITHHELD_PERMISSIONS:
       return l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WITHHELD);
     case ALL_PERMISSIONS:
-    default:
       NOTREACHED();
       return base::string16();
   }
+  NOTREACHED();
+  return base::string16();
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetRetainedFilesHeading() const {
   return l10n_util::GetPluralStringFUTF16(
       IDS_EXTENSION_PROMPT_RETAINED_FILES, GetRetainedFileCount());
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetRetainedDevicesHeading()
     const {
   return l10n_util::GetPluralStringFUTF16(
@@ skipping 383 matching lines @@
         extension_ ? &extension_->permissions_data()->withheld_permissions()
                    : nullptr;
     if (withheld && !withheld->IsEmpty()) {
       prompt_->SetPermissions(
           message_provider->GetPermissionMessages(
               message_provider->GetAllPermissionIDs(*withheld, type)),
           WITHHELD_PERMISSIONS);
     }
   }
 
-  switch (prompt_->type()) {
-    case PERMISSIONS_PROMPT:
-    case RE_ENABLE_PROMPT:
-    case INLINE_INSTALL_PROMPT:
-    case EXTERNAL_INSTALL_PROMPT:
-    case INSTALL_PROMPT:
-    case POST_INSTALL_PERMISSIONS_PROMPT:
-    case REMOTE_INSTALL_PROMPT:
-    case REPAIR_PROMPT:
-    case DELEGATED_PERMISSIONS_PROMPT: {
-      prompt_->set_extension(extension_);
-      break;
-    }
-    case LAUNCH_PROMPT_DEPRECATED:
-    default:
-      NOTREACHED() << "Unknown message";
-      return;
-  }
+  prompt_->set_extension(extension_);
   prompt_->set_icon(gfx::Image::CreateFrom1xBitmap(icon_));
 
   if (show_params_->WasParentDestroyed()) {
     base::ResetAndReturn(&done_callback_).Run(Result::ABORTED);
     return;
   }
 
   g_last_prompt_type_for_tests = prompt_->type();
   did_call_show_dialog_ = true;
 
   if (AutoConfirmPrompt(&done_callback_))
     return;
 
   if (show_dialog_callback_.is_null())
     show_dialog_callback_ = GetDefaultShowDialogCallback();
   base::ResetAndReturn(&show_dialog_callback_)
       .Run(show_params_.get(), base::ResetAndReturn(&done_callback_),
            std::move(prompt_));
 }